Should live on bundle edit form or on individual field edit forms.

Follow-up of #2335645: Implement support for media type plugins (providers).

CommentFileSizeAuthor
#11 2336157_11.patch13.6 KBslashrsm
#9 interdiff.txt2.49 KBslashrsm
#9 2336157_9.patch14.04 KBslashrsm
#7 interdiff.txt855 bytesslashrsm
#7 2336157_7.patch12.39 KBslashrsm
#5 interdiff.txt1004 bytesslashrsm
#5 2336157_5.patch12.38 KBslashrsm
#3 2336157_3.patch12.33 KBslashrsm
#3 Izbor_018.png129.08 KBslashrsm

Comments

slashrsm’s picture

slashrsm commented
Issue tags: +Media Initiative, +sprint
slashrsm’s picture

slashrsm commented
Issue tags: -sprint +D8Media
slashrsm’s picture

slashrsm commented
Issue summary: View changes
Status: Active » Needs review
StatusFileSize
new Izbor_018.png129.08 KB
new 2336157_3.patch12.33 KB

Attached patch adds "Field mapping" section to the media bundle config form:

It gets list of all metadata fields type plugin provides and allows user to select which entity field those should be mapped to.

Had to change field_map schema definition to "ignore" as it was incomplete. We should find some other solution. I am not sure if core provides and data type that could be used. Otherwise we'll have to implement a custom one.

Status: Needs review » Needs work

The last submitted patch, 3: 2336157_3.patch, failed testing.

slashrsm’s picture

slashrsm commented
Status: Needs work » Needs review
StatusFileSize
new 2336157_5.patch12.38 KB
new interdiff.txt1004 bytes

@Berdir suggested to use sequence.

Status: Needs review » Needs work

The last submitted patch, 5: 2336157_5.patch, failed testing.

slashrsm’s picture

slashrsm commented
Status: Needs work » Needs review
StatusFileSize
new 2336157_7.patch12.39 KB
new interdiff.txt855 bytes

Let's see if this passes.

Status: Needs review » Needs work

The last submitted patch, 7: 2336157_7.patch, failed testing.

slashrsm’s picture

slashrsm commented
Status: Needs work » Needs review
StatusFileSize
new 2336157_9.patch14.04 KB
new interdiff.txt2.49 KB

Another try... Passes locally and testbot complains.

Status: Needs review » Needs work

The last submitted patch, 9: 2336157_9.patch, failed testing.

slashrsm’s picture

slashrsm commented
Status: Needs work » Needs review
StatusFileSize
new 2336157_11.patch13.6 KB

Status: Needs review » Needs work

The last submitted patch, 11: 2336157_11.patch, failed testing.

  • slashrsm committed dd7f335 on 8.x-1.x 
    Issue #2336157 by slashrsm: Provide UI for field mapping.
slashrsm’s picture

slashrsm commented
Status: Needs work » Fixed

Committed.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.