Atrium is changing to use local and remote apps, and Mike has decided work tracker should be a local app -- one that comes with the distro by default but can be disabled and enabled via the app interface.

CommentFileSizeAuthor
#14 2335741-oa_worktracker-server-14.patch468 byteshefox
#10 Tasks.png3.06 KBhefox
#10 2335741-oa_worktracker-app-10.patch69.33 KBhefox
#5 2335741-oa_worktracker-app-4.patch65.86 KBhefox
#3 2335741-oa_worktracker-app-3.patch65.21 KBhefox
#2 2335741-oa_worktracker-app-2.patch64.08 KBhefox
#1 2335741-oa_worktracker-app-1.patch1.38 KBhefox

Comments

hefox’s picture

hefox commented
Status: Active » Needs review
StatusFileSize
new 2335741-oa_worktracker-app-1.patch1.38 KB
hefox’s picture

hefox commented
Issue summary: View changes
StatusFileSize
new 2335741-oa_worktracker-app-2.patch64.08 KB
hefox’s picture

hefox commented
StatusFileSize
new 2335741-oa_worktracker-app-3.patch65.21 KB
hefox’s picture

hefox commented
Status: Needs review » Needs work

needs work cause needs icon

hefox’s picture

hefox commented
StatusFileSize
new 2335741-oa_worktracker-app-4.patch65.86 KB

Oh, was already an remote app. Joined the two hook_apps_app_info's

dsnopek’s picture

dsnopek
he/him
Primary language English
Location USA
commented

Thanks, @hefox!

But why is this patch removing oa_worktracker.features.og_features_permission.inc? That seems unrelated to adding Apps support.

hefox’s picture

hefox commented

This is happening with all the oa apps -- apps now has code that does the permissions on install then doesn't touch them after that (from og and user permissions). See the hook_apps_app_info()

:)

dsnopek’s picture

dsnopek
he/him
Primary language English
Location USA
commented

Ah, ok! So, we should probably remove the features lines from oa_worktracker.info as well:

features[og_features_permission][] = node:oa_space:create oa_worktracker_task content
features[og_features_permission][] = node:oa_space:update any oa_worktracker_task content

Otherwise that file will get recreated when the Feature is updated.

hefox’s picture

hefox commented

...Oops, yep XD

Will update next time I roll patch (waiting on icon)

hefox’s picture

hefox commented
StatusFileSize
new 2335741-oa_worktracker-app-10.patch69.33 KB
new Tasks.png3.06 KB

Patch with those removes and icon added.

Also attached icon in case patch doesn't work

hefox’s picture

hefox commented
Status: Needs work » Needs review

  • dsnopek committed aac6a1c on 7.x-2.x authored by hefox 
    Issue #2335741 by hefox: Make into a local atrium app.
dsnopek’s picture

dsnopek
he/him
Primary language English
Location USA
commented
Status: Needs review » Fixed

I applied the patch and then did a drush fu to make sure that everything would stay the same - and it did (with minor reordering in the .info file). I haven't tested installing or anything like that, but I assume you guys have been actively working on the Apps and permission stuff, so I'll trust you. :-) Committed!

hefox’s picture

hefox commented
Issue summary: View changes
Status: Fixed » Needs review
StatusFileSize
new 2335741-oa_worktracker-server-14.patch468 bytes

Sorry for re-opening but figure might as well instead of new issue

need server = openatrium so it's associated with openatrium instead of panopoly

dsnopek’s picture

dsnopek
he/him
Primary language English
Location USA
commented
Status: Needs review » Fixed

Committed, thanks! :-)

  • dsnopek committed 83a1f6a on 7.x-2.x authored by hefox 
    Issue #2335741 by hefox: Make into a local atrium app.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.