Problem/Motivation

The node module has layout styling in node.module.css that is unused by core and contrib themes. This file is also used by 2 separate libraries.

Proposed resolution

Remove node.module.css from node/drupal.node
Swap NodeForm to use node/drupal.node instead
Deprecate node/form library
Remove node-edit-form from umami theme

Remaining tasks

Review

User interface changes

None

API changes

None

Issue fork drupal-2335523

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

lewisnyman’s picture

Issue tags: +Novice

In order to implement this as the current design we need to add new classes to system.admin.css:

.layout-column.third
.layout-column.two-thirds

We then replace these classes:

.layout-node-form => .layout-container
.layout-region => .layout-column
.layout-region-node-main => .two-thirds
.layout-region-node-main => .third
pivica’s picture

Status: Active » Needs review
StatusFileSize
new4.25 KB

Here is a first patch for this - its not just adding two more classes and changing class names in twig template because grid of this form is working little differently then current default grid css from system.admin.css:

  1. Here we have .layout-container inside .layout-container so we get double margins - that is why i added .layout-container--no-margin modifier that removes them when needed.
  2. .layout-container--bigger-gutter .layout-column + .layout-column {
      padding-left: 2em; /* LTR */
    }
    [dir="rtl"] .layout-container--bigger-gutter .layout-column + .layout-column {
      padding-right: 2em;
      padding-left: 0;
    }
    

    Gutter of node edit form is bigger then default one so added .layout-container--bigger-gutter modifier.

  3. .layout-container--bigger-gutter .layout-column + .layout-column {
      padding-left: 2em; /* LTR */
    }
    [dir="rtl"] .layout-container--bigger-gutter .layout-column + .layout-column {
      padding-right: 2em;
      padding-left: 0;
    }
    

    .layout-column.third and .layout-column.two-thirds are on 35% and 65% as they were in original css - not sure about this, guess that 33.3333% and 66.6666% has more sense?

  4. There are no rows for current node form implementation, because how footer with button behaves, that is why currently this code exist in node.module.css
    .node-form .layout-column + .layout-column.layout-region-node-footer {
      padding-left: 0;
    }
    [dir="rtl"] .node-form .layout-column + .layout-column.layout-region-node-footer {
      padding-right: 0;
    }
    

    and that is why for now i leaved previous classes in node-edit-form.html.twig so specific part of form can be targeted when needed by css.

  5. For narrow screens when .toolbar-tray-open kicks in there is additional break point. This works fine, but i am confused a bit with current mixing of units:
    - in grid css we are using 'em' for break points but for widths there is a mix of 'px' and 'rem' units used, for example
    .toolbar-oriented .toolbar-tray-vertical {
      left: -100%; /* LTR */
      position: absolute;
      width: 240px;
      width: 15rem;
    }
    

    Should we maybe switch to rem units in breakpoints also?
    Also why we are using a mixin of 'px' and 'rem' units for width for toolbar, i saw this mixin in other places also when margin is specified for some elements?

Wondering should we maybe introduce more formal grid implementation with 12 column options and one breakpoint for small screens like we have now on 38em?

Beside all this css works OK - tested in Chrome and FF and tested rtl. One difference is small change of 2em in current columns because original css used right padding and our grid use left padding, but this should not be a problem.

idebr’s picture

We then replace these classes:

.layout-node-form => .layout-container
.layout-region => .layout-column
.layout-region-node-main => .two-thirds
.layout-region-node-main => .third

If .two-thirds is a version of .layout-column, should it not be .layout-column--two-thirds according to the BEM naming policy?

lewisnyman’s picture

@idebr Yes you're right, we should add a follow up issue for that.

axe312’s picture

Status: Needs review » Reviewed & tested by the community

Patch looks good, it cleanly removes the custom code from node.module.css. The left over part might be fixed with a proper grid implementation which was already mentioned by Pivica.

The fix with the --no-margin seems bad, but the issue here is that we need a proper grid system which supports nesting of grids. There we should also keep our naming policy in mind. Pivica and me are creating a proposal for proper grid system, ill add the link later on.

Also the change to rem as unit should be done, we should use #2298015: [policy] Document when we should use each CSS unit as follow up here.

lewisnyman’s picture

Status: Reviewed & tested by the community » Needs review
Issue tags: +Needs screenshots

Ok I think the CSS is not ideal but I think we can clean it up more in other issues. We need screenshots to show that it is not broken.

/**
 * The vertical toolbar mode gets triggered for narrow screens, which throws off
 * the intent of media queries written for the viewport width. When the vertical
 * toolbar is on, we need to suppress layout for the original media width + the
 * toolbar width (240px or 15rem). In this case, 15em + 38em.
 */
@media
  screen and (max-width: 52em) {

  .toolbar-vertical.toolbar-tray-open .layout-column {
    float: none;
    width: auto;
  }
  .toolbar-vertical.toolbar-tray-open .layout-column.layout-region-node-secondary {
    padding-left: 0;
  }
}

In #2335531: Replace block placement page layout CSS with reusable layout classes I suggested we move these styles into system.admin.css. At least the parts that only affect layout-column. I don't mind if we do that in this issue or the other one as long as we remove the duplicate code from here once it's been done.

lewisnyman’s picture

axe312’s picture

StatusFileSize
new114.88 KB
new114.91 KB

Here are the screenshots.

The layout difference here is because of the way the gutter is applied to the grid. Before the patch it used padding-right on the left column, so the content was actually 2em smaller than the set value. The new layout classes use padding-left on every element except the first one, that is smarter, but results here in a small change of the form layout.

Lets remove the toolbar code in an follow up ticket, we may fix it directly in the patch for the new proposed grid in #2471791: Improve the CSS layout framework for Drupal's admin interface

axe312’s picture

Issue tags: -Needs screenshots
lewisnyman’s picture

Issue summary: View changes
StatusFileSize
new827.97 KB

I went through this issue with the intention of trying to remove as much custom CSS as possible.

  1. +++ b/core/modules/node/css/node.module.css
    @@ -7,39 +7,17 @@
    +  .node-form .layout-column + .layout-column.layout-region-node-footer {
    +    padding-left: 0;
    ...
    +  [dir="rtl"] .node-form .layout-column + .layout-column.layout-region-node-footer {
    

    I looked at what this CSS was doing and it doesn't seem to fix the regression. The problem here is that the second column is floated left when it should be floated right.

  2. +++ b/core/modules/system/css/system.admin.css
    @@ -33,6 +33,13 @@
    +  .layout-container--bigger-gutter .layout-column + .layout-column {
    

    If we change this class so it's not a variant of the .layout-container than we don't have to require the .layout-container class. Maybe just call it .layout-bigger-gutter?

  3. +++ b/core/modules/system/css/system.admin.css
    @@ -42,6 +49,16 @@
    +.layout-container--no-margin {
    +  margin: 0;
     }
    

    I think that we wouldn't need this if we didn't nest .layout-container. It seems like we could just use the clearfix class instead

lewisnyman’s picture

Status: Needs review » Needs work
axe312’s picture

Assigned: Unassigned » axe312
axe312’s picture

Status: Needs work » Needs review
StatusFileSize
new5.01 KB

This patch fixes the floating issue of the form footer (Save and preview button), moves the bigger gutter modifier to the column and replaces the no margin layout container by a simple div.clearfix.

I had to apply some custom styling to the columns to achieve this. We really need a proper solution for layouting the columns, which we are already discussing about here in Montpellier.

lewisnyman’s picture

Issue summary: View changes
Status: Needs review » Needs work

Nice thanks.

  1. +++ b/core/modules/node/css/node.module.css
    @@ -1,75 +1,59 @@
       .layout-region-node-secondary {
    -    float: right; /* LTR */
    -    width: 35%;
    +    float: right !important;
    ...
    -    float: left;
    +    float: left !important;
    

    Can we do everything possible to avoid using important? It will make our csslint count go up. How about .layout-column.layout-region-node-secondary?
    It also needs the LTR comment next to it

  2. +++ b/core/modules/node/css/node.module.css
    @@ -1,75 +1,59 @@
    +  .layout-region-node-footer {
    +    clear: left;
       }
    

    This should also be moved down so it's about the RTL stlyling. It also needs an LTR comment against it.

  3. +++ b/core/modules/node/css/node.module.css
    @@ -1,75 +1,59 @@
       [dir="rtl"] .layout-region-node-secondary {
    

    This selector should appear directly after the LTR group

  4. +++ b/core/modules/node/css/node.module.css
    @@ -1,75 +1,59 @@
    +@media screen and (max-width: 52em) {
    ...
    -  .toolbar-vertical.toolbar-tray-open .layout-region-node-main,
    -  .toolbar-vertical.toolbar-tray-open .layout-region-node-footer,
    -  .toolbar-vertical.toolbar-tray-open .layout-region-node-secondary {
    +  .toolbar-vertical.toolbar-tray-open .layout-column {
    

    I can't see why but this doesn't seem to apply when it should

  5. +++ b/core/modules/node/css/node.module.css
    @@ -1,75 +1,59 @@
    +  .toolbar-vertical.toolbar-tray-open .layout-column.layout-region-node-secondary {
    +    padding-left: 0;
       }
    

    I guess this also needs RTL styling?

dpetruk’s picture

Status: Needs work » Needs review
StatusFileSize
new4.24 KB

I've done some fixes.

lewisnyman’s picture

Thanks, I've made a few tweaks so this is inline with our coding standards. This is good to go.

idebr’s picture

Status: Needs review » Needs work
  1. +++ b/core/modules/node/css/node.module.css
    @@ -1,47 +1,25 @@
    +  /* This is a temporary fix till we fix the layout-container implementation. */
    

    Let's add a comment what temporary fix actually fixes, so it can be updated later on.

  2. +++ b/core/modules/node/css/node.module.css
    @@ -1,47 +1,25 @@
    +  [dir="ltr"] .layout-region-node-secondary {
         float: right;
    

    The float attribute is being overridden by [dir="rtl"] .layout-column in system.admin.css. This results in the node actions being placed at the very bottom the page, similar to #10

  3. +++ b/core/modules/node/css/node.module.css
    @@ -61,16 +39,15 @@
    + * toolbar width (240px or 15rem). In this case, 15em + 38em.
    ...
    +@media screen and (max-width: 52em) {
    

    These numbers do not match.

marieke_h’s picture

Assigned: axe312 » marieke_h
marieke_h’s picture

Assigned: marieke_h » Unassigned
Status: Needs work » Needs review
StatusFileSize
new4.43 KB
new1.02 KB

1. I didn't really know what to add as a comment here. Is something like this ok?
Is there already an other issue where there is a discussion about the layouting of columns? I wanted to add the link in the comment.

2. It's not clean to use !important here, but I don't really see an other option? If I understand correctly, this is also temporarily code?

3. I updated the numbers to match

lewisnyman’s picture

Issue tags: -Novice
StatusFileSize
new1.12 KB
new9.13 KB

The float attribute is being overridden by [dir="rtl"] .layout-column in system.admin.css. This results in the node actions being placed at the very bottom the page, similar to #10

This is because the system.admin.css is being loaded after node.module.css - this is weird because the rest of the system CSS is always loaded first:

system.libraries.yml

base:
  version: VERSION
  css:
    # Adjust the weights to load these early.
    component:
      css/system.module.css: { every_page: true, weight: -10, }
    theme:
      css/system.theme.css: { every_page: true, weight: -10 }

I modified the system.libraries.yml and node.libraries.yml so that system.admin.css always loads before node.module.css. Once we break up system.admin.css into component files then this would be a lot easier to do properly.

idebr’s picture

Status: Needs review » Needs work

It appears the patch in #20 includes code related to #2408463: Rewrite entity-meta component inline with our CSS standards. The interdiff seems correct.

marieke_h’s picture

Status: Needs work » Needs review
StatusFileSize
new5.12 KB

I updated the patch from #20 to match the interdiff.

emma.maria’s picture

Version: 8.0.x-dev » 8.1.x-dev
Status: Needs review » Needs work
Issue tags: +Needs reroll

The patch in #22 needs a reroll.

kostyashupenko’s picture

Status: Needs work » Needs review
Issue tags: -Needs reroll
StatusFileSize
new5.18 KB

Re-rolled

Status: Needs review » Needs work

The last submitted patch, 24: replace_content-2335523-24.patch, failed testing.

kostyashupenko’s picture

Status: Needs work » Needs review
StatusFileSize
new5.18 KB

Re-rolled again patch #22 for v8.1.x

Status: Needs review » Needs work

The last submitted patch, 26: replace_content-2335523-26.patch, failed testing.

kostyashupenko’s picture

Please pay your attention to https://dispatcher.drupalci.org/job/default/77610/testReport/junit/Theme...

That's why test was not successful

andypost’s picture

Test needs to be fixed according libraries changes

+++ b/core/modules/node/node.libraries.yml
@@ -1,7 +1,7 @@
-    layout:
+    component:

+++ b/core/modules/system/system.libraries.yml
@@ -26,7 +26,7 @@ base:
-    theme:
+    component:

this caused the test to fail

kostyashupenko’s picture

Here appeared a new test core/modules/system/src/Tests/Theme/StableLibraryOverrideTest.php (that's why previous patches was passed)

Version: 8.1.x-dev » 8.2.x-dev

Drupal 8.1.0-beta1 was released on March 2, 2016, which means new developments and disruptive changes should now be targeted against the 8.2.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.2.x-dev » 8.3.x-dev

Drupal 8.2.0-beta1 was released on August 3, 2016, which means new developments and disruptive changes should now be targeted against the 8.3.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.3.x-dev » 8.4.x-dev

Drupal 8.3.0-alpha1 will be released the week of January 30, 2017, which means new developments and disruptive changes should now be targeted against the 8.4.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.4.x-dev » 8.5.x-dev

Drupal 8.4.0-alpha1 will be released the week of July 31, 2017, which means new developments and disruptive changes should now be targeted against the 8.5.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.5.x-dev » 8.6.x-dev

Drupal 8.5.0-alpha1 will be released the week of January 17, 2018, which means new developments and disruptive changes should now be targeted against the 8.6.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.6.x-dev » 8.7.x-dev

Drupal 8.6.0-alpha1 will be released the week of July 16, 2018, which means new developments and disruptive changes should now be targeted against the 8.7.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.7.x-dev » 8.8.x-dev

Drupal 8.7.0-alpha1 will be released the week of March 11, 2019, which means new developments and disruptive changes should now be targeted against the 8.8.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.8.x-dev » 8.9.x-dev

Drupal 8.8.0-alpha1 will be released the week of October 14th, 2019, which means new developments and disruptive changes should now be targeted against the 8.9.x-dev branch. (Any changes to 8.9.x will also be committed to 9.0.x in preparation for Drupal 9’s release, but some changes like significant feature additions will be deferred to 9.1.x.). For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 8.9.x-dev » 9.1.x-dev

Drupal 8.9.0-beta1 was released on March 20, 2020. 8.9.x is the final, long-term support (LTS) minor release of Drupal 8, which means new developments and disruptive changes should now be targeted against the 9.1.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 9.1.x-dev » 9.2.x-dev

Drupal 9.1.0-alpha1 will be released the week of October 19, 2020, which means new developments and disruptive changes should now be targeted for the 9.2.x-dev branch. For more information see the Drupal 9 minor version schedule and the Allowed changes during the Drupal 9 release cycle.

Version: 9.2.x-dev » 9.3.x-dev

Drupal 9.2.0-alpha1 will be released the week of May 3, 2021, which means new developments and disruptive changes should now be targeted for the 9.3.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.3.x-dev » 9.4.x-dev

Drupal 9.3.0-rc1 was released on November 26, 2021, which means new developments and disruptive changes should now be targeted for the 9.4.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.4.x-dev » 9.5.x-dev

Drupal 9.4.0-alpha1 was released on May 6, 2022, which means new developments and disruptive changes should now be targeted for the 9.5.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.5.x-dev » 10.1.x-dev

Drupal 9.5.0-beta2 and Drupal 10.0.0-beta2 were released on September 29, 2022, which means new developments and disruptive changes should now be targeted for the 10.1.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 10.1.x-dev » 11.x-dev

Drupal core is moving towards using a “main” branch. As an interim step, a new 11.x branch has been opened, as Drupal.org infrastructure cannot currently fully support a branch named main. New developments and disruptive changes should now be targeted for the 11.x branch, which currently accepts only minor-version allowed changes. For more information, see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

quietone’s picture

Status: Needs work » Postponed (maintainer needs more info)

Checking in here to find out if this is still relevant to Drupal 10/11.

If this needs to be done, add a comment and set the status to Active. Thanks. Otherwise, if you know this is outdated, close it as such

Thanks!

acbramley’s picture

It looks like this CSS still exists but I wonder if any of it is still relevant anymore? Some of the classes do seem to be used by classy, demo_umami, and starterkit themes but I wonder if they actually do much.

Gin also uses many of these classes so we'd need BC here.

catch’s picture

Could we try to remove the CSS rules and check whether there's any change in Claro or Gin? It would be good to remove unnecessary CSS if we can.

smustgrave’s picture

Status: Postponed (maintainer needs more info) » Needs work

For #48

acbramley’s picture

Issue summary: View changes
Issue tags: +Needs issue summary update

Also need an IS update here, I'm guessing from the existing patches this is just referring to the styles in node.module.css

acbramley’s picture

Looking at node.module.css we have styles for:

1. .layout-region this only has one rule box-sizing: border-box; which Claro also has in its form-two-columns.css. This looks pretty safe to remove
2. .layout-region-node-main and .layout-region-node-footer and .layout-region-node-secondary These classes only appear in 3 places that aren't CSS files. Those are node-edit-form.html.twig in the demo_umami theme, the starterkit_theme, and in gin itself. Gin also has a lot of CSS rules for these same classes.

Funnily enough, none of these classes (apart from layout-region) are on the node form after installing standard profile both with and without the "Use the administration theme when editing or creating content" setting (i.e in Claro and Olivero)

TLDR; these are looking quite safe to remove. I will need to test across a few of these areas as well as with the vertical toolbar enabled as there are some special rules for that too.

acbramley’s picture

To make things even stranger:

node.module.css is in 2 different libraries - node/drupal.node and node/form
Both libraries are only attached in a single place in core - NodeForm.php
Claro removes the node.module.css file from both libraries via libraries-override
stable9 replaces node.module.css from both libraries with its own node.module.css file

I think in this issue we should also remove the node/form library entirely.

acbramley’s picture

Issue summary: View changes
Issue tags: -Needs issue summary update

I've tested across Gin, Claro, and Demo Umami (with editing in admin/fe theme) and these classes aren't used in any of them. I think we can even remove the node-edit-form.html.twig from umami as well as that is not used at all.

acbramley’s picture

Title: Replace content creation page layout CSS with reusable layout classes » Remove node.module.css and node/form library

acbramley’s picture

Status: Needs work » Needs review
smustgrave’s picture

Only question is do we need to deprecate from the node module?

catch’s picture

It would be possible to leave the library empty and deprecate it for removal in Drupal 12 maybe - that would notify when something attaches it or depends on it.

smustgrave’s picture

Is it worth doing? Not sure if anyone depends on the library but have been surprised by less.

acbramley’s picture

It would be possible to leave the library empty

I tried that and you can't, you get an error about an incomplete library

smustgrave’s picture

So is it worth doing the full deprecation and leave the library for now?

catch’s picture

I tried that and you can't, you get an error about an incomplete library

We should open a spin-off about that maybe - could probably check if the library is deprecated or not and allow empty deprecated libraries, but it shouldn't block this one.

Tried to search for usages and didn't get useful results, but it did find one components/content_edit/node_edit_form/node_edit_form.component.yml

https://git.drupalcode.org/search?group_id=2&scope=blobs&search=node%2Ff...

smustgrave’s picture

This is used in seven in contrib. Know that's not core but a lot of sites still use that theme. So what's the concern there if we just remove vs deprecate?

dcam’s picture

This is used in seven in contrib. Know that's not core but a lot of sites still use that theme. So what's the concern there if we just remove vs deprecate?

@smustgrave I took a peek at this issue and wondered wondered how Seven was using the library. But I can't find a reference to either removed library in there. I see Seven's own node library. I've triple-checked, but I admit that maybe I'm just clueless. Still, I wanted to mention it in case you were mistaken. If I've just overlooked it, then please feel free to let me know.

smustgrave’s picture

Status: Needs review » Reviewed & tested by the community

You're right.

Wish we could do a deprecation but the project for components/content_edit/node_edit_form/node_edit_form.component.yml doesn't have a D11 release so as long as this isn't backported shouldn't break that.

catch’s picture

Status: Reviewed & tested by the community » Needs work

Needs a rebase unfortunately.

dcam’s picture

Status: Needs work » Reviewed & tested by the community

Rebased. The conflict was in stable9.info.yml due to the addition of Navigation libraries.

catch’s picture

Status: Reviewed & tested by the community » Needs review
Issue tags: +Needs change record

We need a change record here to inform themes they no longer need to override the library.

dcam’s picture

Status: Needs review » Needs work

I sat down to write the change record and then realized that node.module.css isn't removed from the Node module directory. Is this correct or should it be deleted too? Is it because we can't leave the library empty as noted in #60?

Setting to Needs Work for the change record.

catch’s picture

Looking at this again I think we should remove the file from the node/drupal.node library. Then for the drupal/form library deprecate it without touching the files, and remove the file in Drupal 12. If we don't delete the file yet, we can deprecate the library, if we're not adding the library anywhere in core, then we're not using a deprecated library. I didn't re-read the issue to see if this option was tried, but my previous attempt to suggest a deprecation would have relied on the ability to deprecate an empty library which isn't possible yet.

acbramley’s picture

Title: Remove node.module.css and node/form library » Remove node.module.css from node/drupl.node library and deprecate node/form library
Issue summary: View changes
Status: Needs work » Needs review
Issue tags: -Needs change record
acbramley’s picture

I think I've actioned #70 (as I understand it) but what do we do with Claro and Stable9 that are overriding that (now deprecated) library?

Version: 11.x-dev » main

Drupal core is now using the main branch as the primary development branch. New developments and disruptive changes should now be targeted to the main branch.

Read more in the announcement.

smustgrave’s picture

Can this get a rebase.

dcam’s picture

Status: Needs review » Needs work

I rebased it, but the tests are failing.

acbramley’s picture

Tests are failing due to #72 - not sure what the fix is here.

catch’s picture

I think we can remove the claro and stsble9 overrides given we think this is dead CSS.

Stable9's BC promise only works for keeping old styles in the same file, it really does not work at all when files are being moved around or become unused. And we're planning to move it to contrib anyway.

acbramley’s picture

Status: Needs work » Needs review

Perfect! Rebased and removed the overrides.

smustgrave’s picture

Status: Needs review » Reviewed & tested by the community

Believe feedback for this one has been addressed.

benjifisher’s picture

Since Drupal 11.4.0 and 12.0.0 will be released together, it is unusual to deprecate in 11.4.0 and remove in 12.0.0, but there are exceptions. Should this be one of them?

I notice several comments about removing in D12, but those were before the release of 11.3.0, so maybe they were assuming we would deprecate in 11.3.0 and remove in 12.0.0.

longwave’s picture

Title: Remove node.module.css from node/drupl.node library and deprecate node/form library » Remove node.module.css from node/drupal.node library and deprecate node/form library
Status: Reviewed & tested by the community » Needs work
Issue tags: +Needs followup

What about core/themes/starterkit_theme/templates/content-edit/node-edit-form.html.twig - shouldn't this be deleted here too?

Tagging for a followup where we can actually delete node.module.css as well, we should link that from the comment in Stable9LibraryOverrideTest.

acbramley’s picture

Status: Needs work » Needs review
Issue tags: -Needs followup
dcam’s picture

Status: Needs review » Reviewed & tested by the community

I reviewed the changes since the last RTBC. node-edit-form.html.twig was deleted from the starterkit_theme. The test comment was updated with a working link to the follow-up issue. They look good to me.

andypost’s picture

Not sure that changing stable9 theme makes sense, it should went to obsolete state

  • catch committed 676003e7 on 11.x
    refactor: #2335523 Remove node.module.css from node/drupal.node library...

  • catch committed 378e6520 on main
    refactor: #2335523 Remove node.module.css from node/drupal.node library...
catch’s picture

Status: Reviewed & tested by the community » Fixed

@andypost if we don't change stable9 we have core test coverage that fails, so we need to keep it updated up until we remove it unfortunately.

Committed/pushed to main and 11.x, thanks!

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

smustgrave’s picture

Should we open a follow up to remove the deprecations from main?

acbramley’s picture

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.