Deleted User needs to be removed from the log

I have no problem writing the patch code but how does the signup hook into the user system. Would there need to be some kind of trigger when the user is deleted or would it be better to do the check on the Signup administration page. Do the check on the log and users table before the page loads.

~ Tom

I think I have the solution. I have tested for both ways to delete a user, deleting multiple users at a time from the Admin->User managemt->Users page as well as deleting a single user from the User Account->Edit page.

here is the function I wrote that uses the hook_user():

/**
* Implementatiion of hook_user
* When a user is deleted, remove all instances of that user from the {signup_log} table
*/
function signup_user($type, &$edit, &$user, $category = NULL) {
  switch ($type) {
    case 'delete':
      $uids = array();
      // For a multi-user delete from the Admin -> User management -> Users page
      if(is_array($edit['accounts'])) {
        foreach ($edit['accounts'] as $uid) {
          $uids[] = $uid;
        }
      }
      // For a single-user delete from the User Account -> Edit page
      else {
        $uids[] = $edit['uid'];
      }
      $uid_str = implode(', ', $uids);
      db_query("DELETE FROM {signup_log} WHERE uid IN (%s)", $uid_str);
  }
}

Please let me know what you guys think and if the code can be cleaned up at all that would be great. Also, I don't know how to create .patch files if somebody could show me how than I can submit this as a .patch.

Thanks,
~ Tom Cocca

Thanks for the feedback, I have modified my function, here is the update. Don't have time to figure out the patch file thing run now as I am unfortunately coding on a windows laptop.

Thanks for th safe coding link as well, realized what I was doing wrong with the implode on the placeholder. Each element has to be surrounded by '' even if it is an int? Anyway here is the new function:

/**
* Implementatiion of hook_user
* When a user is deleted, remove all instances of that user from the {signup_log} table
*/
function signup_user($type, &$edit, &$user, $category = NULL) {
  switch ($type) {
    case 'delete':
      // For a multi-user delete from the Admin -> User management -> Users page
      if(is_array($edit['accounts'])) {
        foreach ($edit['accounts'] as $uid) {
          $nid_res = db_query("SELECT nid FROM {signup_log} WHERE uid = %d", $uid);
          while($data = db_fetch_object($nid_res)) {
            signup_cancel_signup($uid, $data->nid);
          }
        }
      }
      // For a single-user delete from the User Account -> Edit page
      else {
        $nid_res = db_query("SELECT nid FROM {signup_log} WHERE uid = %d", $edit['uid']);
        while($data = db_fetch_object($nid_res)) {
          signup_cancel_signup($edit['uid'], $data->nid);
        }
      }
  }
}

Thanks for creating the patch file. I was trying to figure out a way to re-use the statement that calls singup_cancel_signup but didn't have any great ideas. I like yours though.

Also, I'll know from now on to include a space after an if or else if or a foreach. Is this not the case with a while?

Also the break after the case is good practice.

Anyway I tested your patch and it works the exact same. Thanks for your help on this little issue.

~ Tom