Rename task-list.html.twig to maintenance-task-list.html.twig

Thanks @joelpittet!

Patch uploaded. Please review.

https://www.drupal.org/documentation/git/configure has some good example how to configure git to show renames in diffs.

Thanks for the patch @joshi.rohit100! Apparently we don't have any test coverage for this, drupal_common_theme() needs to be updated…

updated patch.

Sorry, I should have been clearer. The actual theme hook, task_list (and usages of it) should be renamed. We don't usually have the templates named differently from the theme hook.

I'm not sure of the logic behind this change? From a theming point of view, why specify that a task list should only be used for maintenance tasks? Couldn't they be used in other situations that we have not yet uncovered? It doesn't fit with the idea of "reusable design components irrespective of content" that we have embraced in our CSS standards.

I think the ideal end result is #1222254: Remove theme_task_list() and call theme('item_list__tasks') instead., but if you look at the template it has a hardcoded "Installation tasks" right in there. So definitely not reusable right now, whatever it's called :)

+++ b/core/includes/install.core.inc
@@ -766,7 +766,7 @@ function install_tasks($install_state) {
- * theme_task_list().
+ * theme_maintenance_task_list().

@@ -775,7 +775,7 @@ function install_tasks($install_state) {
- * @see theme_task_list()
+ * @see theme_maintenance_task_list()

While we're updating these we might as well change them to maintenance-task-list.html.twig because neither of these theme functions exist, pre- or post-patch.

Other than that this is looking good! Thanks @tuutti (and @thamas!).

I'll try this one

Finally I hadn't time yesterday to see this, I left it for the sprint and I'll take it again if nobody resolve it.

Updated per #12.

As a novice at the drupalcon Amsterdam sprint workshop, I have applied the patch.

• The output of git status shows the file has correctly been renamed.
• The changes in core/includes/install.core.inc, core/includes/theme.inc and core/modules/system/src/Controller/DbUpdateController.php now reference the new filename/template

Adding the API change to the issue summary. Thanks everyone!

Committed 63a2332 and pushed to 8.0.x. Thanks!

diff --git a/core/includes/theme.inc b/core/includes/theme.inc
index 681a27e..ef49f54 100644
--- a/core/includes/theme.inc
+++ b/core/includes/theme.inc
@@ -1544,7 +1544,7 @@ function template_preprocess_container(&$variables) {
 /**
  * Prepares variables for maintenance task list templates.
  *
- * Default template: task-list.html.twig.
+ * Default template: maintenance-task-list.html.twig.
  *
  * @param array $variables
  *   An associative array containing:

Fixed on commit.

Thank you @alexpott!

I'm not sure if it was this issue, but it seems suspect that HEAD is looking like this:

Not at a computer right now to check but I suspect that is #1842140: Remove title and wrapper div from item-list.html.twig.

Ah I see, thanks