Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Suggested commit message:
Issue #1885564 by Cottser, SebCorbin, joelpittet, drupalninja99, jenlampton, longwave, aboros, trevorkjorlien, socketwench, shanethehat, mbrett5062, rteijeiro: Convert theme_task_list to Twig template.
Split from #1885564: theme.maintenance.inc (authorize.php) - Convert theme_ functions to Twig
Task
Convert theme_task_list()
to a Twig template
Remaining
- Patch needs review
- Manual testing needed - particularly for authorize.php
Manual testing steps
- task-list.html.twig - visit update.php, look for list in left sidebar under Druplicon - "Verify requirements", "Overview", etc.
Related
#1885714: Remove theme_install_page()
#1885850: Remove theme_update_page()
#1189822: Convert maintenance-page.html.twig to HTML5
Comment | File | Size | Author |
---|---|---|---|
#14 | interdiff.txt | 1.56 KB | star-szr |
#14 | 2329505-14.patch | 3.34 KB | star-szr |
#12 | 2329505-12.patch | 2.64 KB | star-szr |
Comments
Comment #1
joelpittetHere's the split.
Comment #2
joelpittetCleanup of the preprocess and markup update to match changes in HEAD, remove parens and move space inside the span.
Comment #3
joelpittetWhoops, forgot the hook_theme() in both the above and added the wrong class, and those parenthesis are needed.
Comment #4
joelpittetAnd wrong interdiff..argh... sorry... again.
Comment #5
rteijeiro CreditAttribution: rteijeiro commentedIs this extra space inside the span needed?
Comment #6
star-szrIt was there before, so it might not be needed but we should preserve it for now to limit the scope of this to converting to Twig.
Comment #7
rteijeiro CreditAttribution: rteijeiro commentedOk, then it's a RTBC. Update page works as expected and code looks good.
Comment #8
star-szrGreat, thanks @rteijeiro :D
Comment #9
star-szrOne line tweak, and adding a suggested commit message to the issue summary (from the parent issue).
Comment #10
star-szrjoelpittet++
Comment #11
star-szrI'm almost certain this will need a reroll after #2250119: Run updates in a full environment.
Comment #12
star-szrNo major changes, it turns out #2250119: Run updates in a full environment just moved the theme function to theme.inc. That means the 'include' line in drupal_common_theme() should no longer be needed, so I removed it.
Comment #13
joelpittet@Cottser #12 seems to be missing the theme function removal.
Thanks for the re-roll.
Comment #14
star-szrD'oh. Will cancel the last one. Thanks @joelpittet!
Comment #15
joelpittetThank you:) Back to RTBC as per #7
Comment #16
webchickCommitted and pushed to 8.x. Thanks!
Comment #17
webchickAlso, this would be out of scope of this issue, which is just a conversion, but there's no way I would've associated a template called "task-list.html.twig" with "a list of maintenance tasks to perform." Maybe we could discuss this in a follow-up?
Comment #19
joelpittet@webchick done #2335003: Rename task-list.html.twig to maintenance-task-list.html.twig
Thanks for committing:)