Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.If number of items per page is exposed in Search API view, cache key does not take this value into account, and therefore the view display the same (cached) number of items.
| Comment | File | Size | Author |
|---|---|---|---|
| #4 | search_api-views_cache_items_per_page-2334727-3.patch | 880 bytes | Alex Bukach |
Comments
Comment #1
Alex Bukach CreditAttribution: Alex Bukach commentedComment #2
drunken monkeyThanks for reporting this, and providing a patch!
I think it's a bit too narrow, though. As I see, there is also an option to expose the offset? Instead of using the exposed data directly, we should maybe just use all the pager data of the view, instead of just the current page.
The attached patch should solve this and hopefully cover all cases – I think. Please test!
Comment #4
Alex Bukach CreditAttribution: Alex Bukach commentedAnother iteration.
Comment #5
Alex Bukach CreditAttribution: Alex Bukach commenteddrunken monkey, with this little amendment the patch works fine as well. Thanks!
Comment #6
drunken monkeyAh, oops! I remember I spotted this error, too, but it seems I didn't recreate the patch file after fixing that … Thanks for posting a corrected version, and good to hear this now works, too.
Committed.
Thanks again!
Comment #9
drunken monkeyI think this needs to be ported to D8.
Comment #10
drunken monkeyComment #11
adooo CreditAttribution: adooo as a volunteer commentedThe patch is gone from 7.x-1.x
Comment #12
drunken monkeyOK, thanks a lot for verifying this!
Then we can close this again after all.