Hi there.

I stumbled across this when trying to write a rule that runs when a user edits their page. By process of elimination I discovered it was in the invite_notifications module.

I'm not 100% sure what is being done here. Is it a check for a flag that is set when a user accepts an invite? And then unset the flag after the message has been displayed?

If so my patch isn't quite correct (you should check the flag at the top). My patch just treads lightly and checks the flag state before overwriting it with the same value.

The alternative would be:

  if (isset($user->data['notification_received']) && $user->data['notification_received']) != FALSE ) {
...
  }

Patch to follow.

CommentFileSizeAuthor
#1 invite-notification-2334559-1.patch610 bytesqueenvictoria

Comments

queenvictoria’s picture

queenvictoria commented
StatusFileSize
new invite-notification-2334559-1.patch610 bytes
queenvictoria’s picture

queenvictoria commented
Status: Active » Needs work
davery’s picture

davery commented

I think the fix is to change line 20 of invite_notifications.module to:

  if (isset($account->data['notification_received']) && $account->data['notification_received'] == TRUE) {

See lines 142 & 173. Otherwise notifications_received has no purpose as it's presumably always set after installation.

davery’s picture

davery commented
Status: Needs work » Needs review

i think this is the change i'm supposed to make to get the maintainer to look...

renatog’s picture

renatog commented
Status: Needs review » Reviewed & tested by the community

Really works good

  • RenatoG committed d3162b8 on 7.x-4.x authored by queenvictoria 
    Issue #2334559 by queenvictoria, davery, RenatoG: Invite notifications...
renatog’s picture

renatog commented
Status: Reviewed & tested by the community » Fixed

Committed to the dev branch.

Best,

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.