Problem/Motivation

#2317135: Transparent background in autocomplete widget fixed a CSS problem but introduced the following problem:

White background on the top corners of the dialog box and changed the original color of the title bar.

Proposed resolution

Use another css class ".ui-autocomplete" instead of ".ui-widget-content".

Remaining tasks

None

User interface changes

Before
After

API changes

None

CommentFileSizeAuthor
#15 2334307-15-css-dialog.patch515 bytesamitgoyal
#13 2334307-13-css-dialog.patch471 bytesyvesvanlaer
#12 2334307-12-css-dialog.patch471 bytesyvesvanlaer
#5 2334307-5-css-dialog.patch473 bytesyvesvanlaer
#1 2334307-1-css-dialog.patch499 bytesyvesvanlaer
Screen Shot 2014-09-07 at 11.30.05.png11.98 KByvesvanlaer
Screen Shot 2014-09-07 at 11.25.07.png11.58 KByvesvanlaer

Comments

yvesvanlaer’s picture

yvesvanlaer commented
Status: Active » Needs review
Issue tags: +DUGBE1409
StatusFileSize
new 2334307-1-css-dialog.patch499 bytes
wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Issue summary: View changes
yvesvanlaer’s picture

yvesvanlaer commented
Issue summary: View changes
wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Status: Needs review » Needs work
Issue tags: +CSS, +Quickfix

Only one nitpick:

+++ b/core/themes/seven/css/jquery.ui.theme.css
@@ -382,3 +381,10 @@
+}
\ No newline at end of file

Please add a trailing newline.

So, #2317135: Transparent background in autocomplete widget fixed a CSS problem, but in doing so has caused the regression described in the issue summary. This patch keeps the fix added in that issue, but applies it only to the intended DOM elements rather than too many. That's it.

Once the nitpick above is fixed, I think this is RTBC.

yvesvanlaer’s picture

yvesvanlaer commented
Status: Needs work » Needs review
StatusFileSize
new 2334307-5-css-dialog.patch473 bytes
aspilicious’s picture

aspilicious commented
Status: Needs review » Reviewed & tested by the community
wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented

RTBC+1

Thanks, yvesvanlaer — great catch!

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 5: 2334307-5-css-dialog.patch, failed testing.

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Issue tags: +Needs reroll

Something must've changed. Needs a quick reroll.

Status: Needs work » Needs review

yvesvanlaer queued 5: 2334307-5-css-dialog.patch for re-testing.

Status: Needs review » Needs work

The last submitted patch, 5: 2334307-5-css-dialog.patch, failed testing.

yvesvanlaer’s picture

yvesvanlaer commented
StatusFileSize
new 2334307-12-css-dialog.patch471 bytes

Something went wrong indeed. There were 2+'s... Correct patch.

yvesvanlaer’s picture

yvesvanlaer commented
Status: Needs work » Needs review
StatusFileSize
new 2334307-13-css-dialog.patch471 bytes

Now with status "Needs review"

Status: Needs review » Needs work

The last submitted patch, 13: 2334307-13-css-dialog.patch, failed testing.

amitgoyal’s picture

amitgoyal commented
Status: Needs work » Needs review
Issue tags: -Needs reroll
StatusFileSize
new 2334307-15-css-dialog.patch515 bytes

Reroll of #13.

josevitalsouto’s picture

josevitalsouto
Primary language Portuguese, Brazil
Location RN
commented
Status: Needs review » Reviewed & tested by the community
alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Fixed

Committed d481203 and pushed to 8.0.x. Thanks!

  • alexpott committed d481203 on 8.0.x 
    Issue #2334307 by yvesvanlaer, amitgoyal: Fixed Dialog box has white top...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.