Hi,
When i try to enable this module it does not work and I get an error (Currently using JW Player Please consult README.txt for installation instructions.)
I followed the README.txt to the letter and have downloaded and placed the JWplayer library to sites/all/libraries/jwplayer so either the README.txt is giving the wrong instructions what the should be the folder name of jwplayer or something within the JW Player itself is bugged.

Comments

rohlizde’s picture

Ive got exactly same problem.

junkuncz’s picture

A quick, and dirty solution from me:

Change in the .install file this function for this way:

function jw_player_requirements($phase) {
  $requirements = array();

  // Ensure translations don't break at install time
  $t = get_t();

  $requirements['jw_player'] = array(
    'title' => $t('JW Player'),
    'severity' => REQUIREMENT_OK,
  );

    $libs = libraries_get_libraries();

  if (array_key_exists('jwplayer', $libs)) {
    $requirements['jw_player']['value'] = t('Self-Hosted');
        $key = variable_get('jw_player_key', NULL);
  }
  elseif ($account_token = variable_get('jw_player_account_token', false)) {
      $requirements['jw_player']['value'] = t('Cloud-Hosted');
    }
  else {
  $requirements['jw_player']['value'] = $t('Please consult README.txt for installation instructions.');
  $requirements['jw_player']['severity'] = REQUIREMENT_ERROR;
  }

  return $requirements;
}

It helped for me, but it isn't a good thing, I will write a correct patch for this problem.

Balint

botris’s picture

Confirming this critical bug, not possible to enable module...
Confirming #2 as 'solution'

damienmckenna’s picture

Status: Active » Needs review
StatusFileSize
new1.24 KB

This should work.

andypost’s picture

StatusFileSize
new2.51 KB

Suppose we should check library only at runtime because library is not needed with cloud-hosted library.
Also fixed the absence of description for error.
PS: RTBC for me

milovan’s picture

#5 works for me as well, thanks!

andypost’s picture

Please one more to rtbc and make a fixed release

deadscary’s picture

#5 works fine for me.

andypost’s picture

Version: 7.x-2.0-beta2 » 7.x-2.x-dev
Status: Needs review » Reviewed & tested by the community

There's 2 peer reviews, so we need maintainer asap, and new beta

rickvug’s picture

@andypost I'd love to see more active maintenance of this module. For what it is worth here's the list of committers (beyond myself): Berdir, btopro, dwkitchen, ipo4ka704, jarrodirwin, kungfuchris, mongolito404, recrit, skilip, snig. I haven't made commits to the module for a long while but others have. The 2.x branch is where work is happening. IMO work should concentrate on making 2.x the only supported branch and ensure that there is an upgrade path for 1.x to a new 2.x release that is marked as stable.

zuernbernhard’s picture

Thanks for the patch from #5. How can I help to get it into the module ?

damienmckenna’s picture

zuernbernhard’s picture

Hi Damien,

I have to excuse me for the ambiguity. I'm meant: "How can I help to get the Patch into the Module-Code on Drupal.org". I already applied it locally. But i don't want to do this again and again every time a Module update is available.

damienmckenna’s picture

@zuernBernhard: Ah, sorry ;) Ultimately one of the comaintainers needs to commit it, or someone else needs to join as a comaintainer.

ciss’s picture

Status: Reviewed & tested by the community » Fixed

See #15.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.