I'd like to have an Invert checkbox for the Required tamper. This makes it possible to filter out items that have a field filled. For instance, when harvesting tweets, I want to filter out all tweets that have an empty 'source_status_id_str' (these are retweets).

CommentFileSizeAuthor
#5 2333547-4-add-invert-to-required.patch1.76 KBBarisW
#3 2333547-3-add-invert-to-required.patch1.04 KBBarisW
#1 add-invert-to-required.patch1.19 KBBarisW

Comments

BarisW’s picture

BarisW commented
Status: Active » Needs review
StatusFileSize
new add-invert-to-required.patch1.19 KB

Status: Needs review » Needs work

The last submitted patch, 1: add-invert-to-required.patch, failed testing.

BarisW’s picture

BarisW commented
Status: Needs work » Needs review
StatusFileSize
new 2333547-3-add-invert-to-required.patch1.04 KB

Try again testbot

Status: Needs review » Needs work

The last submitted patch, 3: 2333547-3-add-invert-to-required.patch, failed testing.

BarisW’s picture

BarisW commented
Status: Needs work » Needs review
StatusFileSize
new 2333547-4-add-invert-to-required.patch1.76 KB

Now with updated tests.

BarisW’s picture

BarisW commented

8 months later without any review. Anyone?

twistor’s picture

twistor commented
Status: Needs review » Needs work

+ if (!$settings['invert']) {

We need a empty() check here, since this is a new setting, existing systems won't have it.

I actually think this could be a new plugin, (named empty?). It seems like it will be hard to discover when people are looking through the list.

  • twistor committed 9ae706e on 7.x-1.x authored by BarisW 
    Issue #2333547 by BarisW, twistor: Add invert settings to the Required...
twistor’s picture

twistor commented
Status: Needs work » Fixed
BarisW’s picture

BarisW commented

Great, thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.