Allow to limit the nodes to migrate by node type

Yeah I like it, especially if it's that simple. +1 from me.

Had a quick look over this and it looks good. I'll try give it a proper test a the weekend.

Would be good to tidy up the serialized strings mentioned below.

1. +++ b/core/modules/migrate_drupal/tests/src/Unit/source/d6/NodeRevisionByNodeTypeTest.php
   @@ -0,0 +1,338 @@
   +        'widget_settings' => 'a:4:{s:4:"rows";i:5;s:4:"size";s:2:"60";s:13:"default_value";a:1:{i:0;a:2:{s:5:"value";s:0:"";s:14:"_error_element";s:42:"default_value_widget][field_test][0][value";}}s:17:"default_value_php";N;}',
   +        'display_settings' => 'a:6:{s:6:"weight";s:2:"31";s:6:"parent";s:0:"";s:5:"label";a:1:{s:6:"format";s:5:"above";}s:6:"teaser";a:2:{s:6:"format";s:7:"default";s:7:"exclude";i:0;}s:4:"full";a:2:{s:6:"format";s:7:"default";s:7:"exclude";i:0;}i:4;a:2:{s:6:"format";s:7:"default";s:7:"exclude";i:0;}}',
   

   Can we make these arrays and then call serialize. I think we decide that was the clearest way elsewhere.

2. +++ b/core/modules/migrate_drupal/tests/src/Unit/source/d6/NodeRevisionByNodeTypeTest.php
   @@ -0,0 +1,338 @@
   +        'global_settings' => 'a:4:{s:15:"text_processing";s:1:"0";s:10:"max_length";s:0:"";s:14:"allowed_values";s:0:"";s:18:"allowed_values_php";s:0:"";}',
   ...
   +        'db_columns' => 'a:1:{s:5:"value";a:5:{s:4:"type";s:4:"text";s:4:"size";s:3:"big";s:8:"not null";b:0;s:8:"sortable";b:1;s:5:"views";b:1;}}',
   

   Same for these.

3. +++ b/core/modules/migrate_drupal/tests/src/Unit/source/d6/NodeRevisionByNodeTypeTest.php
   @@ -0,0 +1,338 @@
   +        'widget_settings' => 'a:4:{s:4:"rows";i:5;s:4:"size";s:2:"60";s:13:"default_value";a:1:{i:0;a:2:{s:5:"value";s:0:"";s:14:"_error_element";s:42:"default_value_widget][field_test][0][value";}}s:17:"default_value_php";N;}',
   +        'display_settings' => 'a:6:{s:6:"weight";s:2:"31";s:6:"parent";s:0:"";s:5:"label";a:1:{s:6:"format";s:5:"above";}s:6:"teaser";a:2:{s:6:"format";s:7:"default";s:7:"exclude";i:0;}s:4:"full";a:2:{s:6:"format";s:7:"default";s:7:"exclude";i:0;}i:4;a:2:{s:6:"format";s:7:"default";s:7:"exclude";i:0;}}',
   ...
   +        'global_settings' => 'a:4:{s:15:"text_processing";s:1:"0";s:10:"max_length";s:0:"";s:14:"allowed_values";s:0:"";s:18:"allowed_values_php";s:0:"";}',
   ...
   +        'db_columns' => 'a:1:{s:5:"value";a:5:{s:4:"type";s:4:"text";s:4:"size";s:3:"big";s:8:"not null";b:0;s:8:"sortable";b:1;s:5:"views";b:1;}}',
   

   Few more

OK, re-rolled this issue and fixed the formatting things I mentioned just before. Also fixed the NodeByNodeTypeTest.

+++ b/core/modules/migrate_drupal/tests/src/Unit/source/d6/NodeByNodeTypeTest.php
@@ -0,0 +1,128 @@
+    // Add another row with an article node and make sure it is not migrated.

Shouldn't this comment be above line 89? Seems out of place here.

Also - while the changes/additions to the automated tests look good, I have to admit that I'm still trying to figure out the difference between the tests in core/modules/migrate_drupal/src/Tests vs. the tests in core/modules/migrate_drupal/tests

Finally, once this gets committed, we'll need to document it - probably here, I assume: https://www.drupal.org/node/2129649

-mike

Thanks for the review.

The difference between the tests are that unit tests live under core/modules/migrate_drupal/tests where as integration tests live under core/modules/migrate_drupal/src/Tests

Looks great!

Thanks for the explanation on unit vs. integration tests.

-mike

the log field needed to be added to the revision fields.

Committed 807e561 and pushed to 8.0.x. Thanks!