Remove SortArray::sortByWeightAndTitle

want to see what this would look like.

not sure if the Language::sort() should be typehinted with Language or LanguageInterface.

note #2246679: Make Language module's LanguageInterface (to be ConfigurableLanguageInterface) extend Core's LanguageInterface got in.

Maybe sort() should be on the LanguageInterface. It is not now.

ConfigurableLanguage gets its sort() from ConfigEntityBase. (which accesses the weight and label properties directly.)

oops. totally the wrong file. (I'll cancel that test)
here is the correct one.

collecting other issues I think have delt with this sort.

messed up the brackets.

thanks.

read through the changes...

change to the sort to save the weights instead of getWeight each time. ok.

type hinting on the interface, k.

adds configurable language objects to the sort test. seems like a good idea to have a test that sorts an array made up of Language and ConfigurableLanguage. (not sure if we should add that in this issue, but seems fine, as before #2246679: Make Language module's LanguageInterface (to be ConfigurableLanguageInterface) extend Core's LanguageInterface we could not do it. Now we can and since ConfigurableLanguage's are now LanguageInterface things, and we are changing the Language::sort() seems like a good idea to extend the test coverage.)

I made some small changes to the data provider to keep the same pattern as the Language things had before, and keep the tests only testing what they were before (there was a test that had no ties in weight).

---

I dont understand why we have to make a new EntityType to use, instead of configurable_language.

Maybe the test is not really testing what would happen when sorting an array that has some ConfigurableLanguage.

random fail due to #2330751: Random test failures everywhere due to ->with(Request::create())

Parameter 0 for invocation Symfony\Component\Routing\Matcher\RequestMatcherInterface::matchRequest(Symfony\Component\HttpFoundation\Request Object (...)) does not match expected value.

Drupal\Tests\Core\UrlTest

(uploaded same patch again, so the test results can be preserved in case that is helpful for the random fail issue)

yeah, I thought of that, but it does sort an array of languages. :)

Just a little comment fix about types.

If we are ok with the mock in the test, then I guess this is ready.

after berdir pointed out that this test lives in the place for core components, and that it was strange to be using something from a module,

I took out the configurablelanguage bit. that can go in its own test. #2334483: add test for sorting an array of languages that are Language and ConfigurableLanguage to show the sort() will work for configurable languages too.

maybe we should mock something that implements the language interface and add it too, which could be added here... but I think this is good enough to be ok for now, and we can expand it in other issue. #2334477: expand Language::sort() test coverage to show it works with other objects that implement the LanguageInterface

So.. I think we can agree on this. Get this in, then work on the others.
This will also unblock at least some things.