As far as I can see, this code serves no purpose anymore - it's leftover from #1468210: Remove special $user->uid == 1 check in file_validate_size() when the code actually did need to do things as a specific user account.

CommentFileSizeAuthor
#7 file-validate-size-test-cleanup-2331151-7.patch1.01 KBDevin Carlson
#3 file-validate-size-test-cleanup-2331151-3.patch800 bytesDavid_Rothstein
#1 file-validate-size-test-cleanup-2331151-1.patch793 bytesDavid_Rothstein
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

David_Rothstein’s picture

David_Rothstein CreditAttribution: David_Rothstein commented
Status: Active » Needs review
FileSize
file-validate-size-test-cleanup-2331151-1.patch793 bytes

Status: Needs review » Needs work

The last submitted patch, 1: file-validate-size-test-cleanup-2331151-1.patch, failed testing.

David_Rothstein’s picture

David_Rothstein CreditAttribution: David_Rothstein commented
Status: Needs work » Needs review
FileSize
file-validate-size-test-cleanup-2331151-3.patch800 bytes

Trying again...

swentel’s picture

swentel CreditAttribution: swentel commented
Status: Needs review » Reviewed & tested by the community
alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott commented
Version: 8.0.x-dev » 7.x-dev
Status: Reviewed & tested by the community » Patch (to be ported)

Committed ee91cb0 and pushed to 8.0.x. Thanks!

  • alexpott committed ee91cb0 on 8.0.x 
    Issue #2331151 by David_Rothstein: Remove leftover code in...
Devin Carlson’s picture

Devin Carlson CreditAttribution: Devin Carlson commented
Status: Patch (to be ported) » Needs review
FileSize
file-validate-size-test-cleanup-2331151-7.patch1.01 KB

Backport of #3.

mgifford’s picture

mgifford
he/him
Primary language English
CreditAttribution: mgifford commented

Seems safe to mark this RTBC then. The functionality to run the test as a different user has been removed in d7 too. It's not a straight backport, but looks like there would be no problems by removing this extra code.

dcam’s picture

dcam CreditAttribution: dcam commented
Status: Needs review » Reviewed & tested by the community

Agreed. The code can go. RTBC.

David_Rothstein’s picture

David_Rothstein CreditAttribution: David_Rothstein commented
Status: Reviewed & tested by the community » Fixed

Committed to 7.x - thanks!

  • David_Rothstein committed a4b517f on 7.x 
    Issue #2331151 by David_Rothstein, Devin Carlson: Remove leftover code...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.