Meta issue: #2205673: [meta] Remove all @deprecated functions marked "remove before 8.0"

Only the function exists, the usage of the function is already removed.

CommentFileSizeAuthor
#28 remove-module-invoke-2330181-28.patch1.02 KBranjeet.paliwal
#26 remove-module-invoke-2330181-22.patch1017 bytesgaurav_varshney
#17 remove-module-invoke-2330181-17.patch1019 bytesesod
#10 remove-module-invoke-2330181-10.patch1019 bytesjoshi.rohit100
#8 remove-module-invoke-2330181-8.patch1019 bytesoriol_e9g
#5 drupal8-remove-module_invoke-2330181-5.patch1019 bytespushpinderchauhan
#1 drupal8-remove-module_invoke-2330181-1.patch60.12 KBashutoshsngh

Comments

ashutoshsngh’s picture

ashutoshsngh commented
StatusFileSize
new drupal8-remove-module_invoke-2330181-1.patch60.12 KB
ashutoshsngh’s picture

ashutoshsngh commented
Status: Needs work » Needs review

Status: Needs review » Needs work

The last submitted patch, 1: drupal8-remove-module_invoke-2330181-1.patch, failed testing.

berdir’s picture

berdir
Primary language German
Location Switzerland
commented

Patch also contains the unrelated language_load() changes.

pushpinderchauhan’s picture

pushpinderchauhan commented
Status: Needs work » Needs review
StatusFileSize
new drupal8-remove-module_invoke-2330181-5.patch1019 bytes

Removed unwanted code.

Status: Needs review » Needs work

The last submitted patch, 5: drupal8-remove-module_invoke-2330181-5.patch, failed testing.

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
commented
Issue tags: -Novice. @deprecated +@deprecated
oriol_e9g’s picture

oriol_e9g
Primary language Catalan
Location Barcelona
commented
Status: Needs work » Needs review
StatusFileSize
new remove-module-invoke-2330181-8.patch1019 bytes

Status: Needs review » Needs work

The last submitted patch, 8: remove-module-invoke-2330181-8.patch, failed testing.

joshi.rohit100’s picture

joshi.rohit100
he/him
Primary language Hindi
Location Delhi, India
commented
Status: Needs work » Needs review
StatusFileSize
new remove-module-invoke-2330181-10.patch1019 bytes

Updated patch

Status: Needs review » Needs work

The last submitted patch, 10: remove-module-invoke-2330181-10.patch, failed testing.

Status: Needs work » Needs review

Jeroen queued 10: remove-module-invoke-2330181-10.patch for re-testing.

Status: Needs review » Needs work

The last submitted patch, 10: remove-module-invoke-2330181-10.patch, failed testing.

jeroent’s picture

jeroent
Primary language Dutch
Location 🇧🇪
commented

Patch is failing because drush uses the module_invoke function, but this was recently committed : https://github.com/bfr/drush/commit/e64ea55d069dabd248a0f15d5c2e2ef5f4e4...

Status: Needs work » Needs review

ribel queued 10: remove-module-invoke-2330181-10.patch for re-testing.

Status: Needs review » Needs work

The last submitted patch, 10: remove-module-invoke-2330181-10.patch, failed testing.

esod’s picture

esod commented
StatusFileSize
new remove-module-invoke-2330181-17.patch1019 bytes

Since module_invoke() is added to drush as drush_module_invoke() ( see ~/.composer/vendor/drush/drush/commands/core/drupal/environment.inc line 223), resubmitting the patch for review.

esod’s picture

esod commented
Status: Needs work » Needs review
botanic_spark’s picture

botanic_spark commented
Status: Needs review » Reviewed & tested by the community

The patch #17 applies cleanly.

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 17: remove-module-invoke-2330181-17.patch, failed testing.

esod’s picture

esod commented

I think my patch failed because the testbot for drush needs to be updated. Please see comment #14. The only difference between https://github.com/bfr/drush/commit/e64ea55d069dabd248a0f15d5c2e2ef5f4e4... and what's in my drush/commands/core/drupal/environment.inc is module_invoke() is named drush_module_invoke().

I'm attempting to run the tests on my local, so I can be sure. How can we tell if the testbot for drush needs to be updated and, if it does need to be updated, how do we update it?

Status: Needs work » Needs review

tadityar queued 17: remove-module-invoke-2330181-17.patch for re-testing.

Status: Needs review » Needs work

The last submitted patch, 17: remove-module-invoke-2330181-17.patch, failed testing.

Status: Needs work » Needs review

sivaji@knackforge.com queued 17: remove-module-invoke-2330181-17.patch for re-testing.

Status: Needs review » Needs work

The last submitted patch, 17: remove-module-invoke-2330181-17.patch, failed testing.

gaurav_varshney’s picture

gaurav_varshney commented
Status: Needs work » Needs review
StatusFileSize
new remove-module-invoke-2330181-22.patch1017 bytes

Status: Needs review » Needs work

The last submitted patch, 26: remove-module-invoke-2330181-22.patch, failed testing.

ranjeet.paliwal’s picture

ranjeet.paliwal commented
Status: Needs work » Needs review
StatusFileSize
new remove-module-invoke-2330181-28.patch1.02 KB

Status: Needs review » Needs work

The last submitted patch, 28: remove-module-invoke-2330181-28.patch, failed testing.

RavindraSingh’s picture

RavindraSingh commented
Status: Needs work » Postponed (maintainer needs more info)

drush needs to be updated to pass the test if removing module_invoke function from bootstrap.inc.

So positioning thing issue to the for more information why https://github.com/bfr/drush/commit/e64ea55d069dabd248a0f15d5c2e2ef5f4e4... was added.

pfrenssen’s picture

pfrenssen
Location Sofia
commented
Status: Postponed (maintainer needs more info) » Postponed

This is postponed on #2404923: Upgrade Drush on qa.d.o.

rickvug’s picture

rickvug commented
Status: Postponed » Active

#2404923: Upgrade Drush on qa.d.o is now done.

Status: Active » Needs review

rickvug queued 28: remove-module-invoke-2330181-28.patch for re-testing.

jeroent’s picture

jeroent
Primary language Dutch
Location 🇧🇪
commented
Status: Needs review » Reviewed & tested by the community

Tests pass and no occurrences of module_invoke left so RTBC. + Assigned it to this CR: https://www.drupal.org/node/1894902

RavindraSingh’s picture

RavindraSingh commented

+1, Awesome

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Fixed

Committed 49cdfed and pushed to 8.0.x. Thanks!

The beta evaluation is in the meta issue.

  • alexpott committed 49cdfed on 8.0.x 
    Issue #2330181 by esod, ashutoshsngh, gaurav_varshney, ranjeet.paliwal,...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.