The 2026 Drupal Business Survey is open. Your response will help shape the future of the Drupal business ecosystem.Meta issue: #2205673: [meta] Remove all @deprecated functions marked "remove before 8.0"
Only the function exists, the usage of the function is already removed.
| Comment | File | Size | Author |
|---|---|---|---|
| #28 | remove-module-invoke-2330181-28.patch | 1.02 KB | ranjeet.paliwal |
| #26 | remove-module-invoke-2330181-22.patch | 1017 bytes | gaurav_varshney |
| #17 | remove-module-invoke-2330181-17.patch | 1019 bytes | esod |
| #10 | remove-module-invoke-2330181-10.patch | 1019 bytes | joshi.rohit100 |
| #8 | remove-module-invoke-2330181-8.patch | 1019 bytes | oriol_e9g |
Comments
Comment #1
ashutoshsngh commentedComment #2
ashutoshsngh commentedComment #4
berdirPatch also contains the unrelated language_load() changes.
Comment #5
pushpinderchauhan commentedRemoved unwanted code.
Comment #7
tim.plunkettComment #8
oriol_e9gComment #10
joshi.rohit100Updated patch
Comment #14
jeroentPatch is failing because drush uses the module_invoke function, but this was recently committed : https://github.com/bfr/drush/commit/e64ea55d069dabd248a0f15d5c2e2ef5f4e4...
Comment #17
esod commentedSince module_invoke() is added to drush as drush_module_invoke() ( see ~/.composer/vendor/drush/drush/commands/core/drupal/environment.inc line 223), resubmitting the patch for review.
Comment #18
esod commentedComment #19
botanic_spark commentedThe patch #17 applies cleanly.
Comment #21
esod commentedI think my patch failed because the testbot for drush needs to be updated. Please see comment #14. The only difference between https://github.com/bfr/drush/commit/e64ea55d069dabd248a0f15d5c2e2ef5f4e4... and what's in my drush/commands/core/drupal/environment.inc is module_invoke() is named drush_module_invoke().
I'm attempting to run the tests on my local, so I can be sure. How can we tell if the testbot for drush needs to be updated and, if it does need to be updated, how do we update it?
Comment #26
gaurav_varshney commentedComment #28
ranjeet.paliwal commentedComment #30
RavindraSingh commenteddrush needs to be updated to pass the test if removing module_invoke function from bootstrap.inc.
So positioning thing issue to the for more information why https://github.com/bfr/drush/commit/e64ea55d069dabd248a0f15d5c2e2ef5f4e4... was added.
Comment #31
pfrenssenThis is postponed on #2404923: Upgrade Drush on qa.d.o.
Comment #32
rickvug commented#2404923: Upgrade Drush on qa.d.o is now done.
Comment #34
jeroentTests pass and no occurrences of module_invoke left so RTBC. + Assigned it to this CR: https://www.drupal.org/node/1894902
Comment #35
RavindraSingh commented+1, Awesome
Comment #36
alexpottCommitted 49cdfed and pushed to 8.0.x. Thanks!
The beta evaluation is in the meta issue.