ECK: Autolabel set on insert; reset to %AutoEntityLabel% on subsquent saves.

I was having this same issue with Inline Entity Forms, but I patched it differently. See attached.

Also, this is my very first patch file following the directions here: https://www.drupal.org/node/707484

Hopefully I didn't screw it up =P

Patch #2 worked for me as well.

(My scenario was related to the Inline Entity Form problem)

It may be a better solution to check for reset or "%AutoEntityLabel%" instead of always setting reset to true. That's just a suggestion though, I'm fine with how patch #2 currently works.

It may be a better solution to check for reset or "%AutoEntityLabel%" instead of always setting reset to true. That's just a suggestion though, I'm fine with how patch #2 currently works.

That sounds like a good idea. I would rather not add special cases for specific modules... ;-)

I'm submitting my patch that checks for both empty and "%AutoEntityLabel%". Because I needed to use some values from the $settings array, I had to change the order of the logic. With that in mind, i chose to make the steps pretty verbose for easier reading over fewer lines of code.

@broxen, thank you so much for creating the issue related to inline entity forms. Had I not found that issue, it could have taken me a while to figure out what was going on or I'd have ditch the idea of using this module all together.

@bforchhammer, this module is fantastic! Thanks for your work!

Thanks for your patch, looks good overall!

A few minor things:

1. +++ b/auto_entitylabel.module
   @@ -195,13 +195,40 @@ function auto_entitylabel_field_attach_presave($entity_type, $entity) {
   + * @param bool $reset Forces the label to be set, even if a title has already been set.
   

   Line too long (>80). Maybe just move @param descriptions into new line... :)

2. +++ b/auto_entitylabel.module
   @@ -195,13 +195,40 @@ function auto_entitylabel_field_attach_presave($entity_type, $entity) {
   +      || $entity->{$settings['title']} == '%AutoEntityLabel%');
   

   Let's put the %AutoEntityLabel% string into a constant at the top of the file.

3. +++ b/auto_entitylabel.module
   @@ -195,13 +195,40 @@ function auto_entitylabel_field_attach_presave($entity_type, $entity) {
   +    // Check if the label is empty or forced and makes sure an existing label isn't overwritten if the autolabel is optional.
   

   Line too long :)

+++ b/auto_entitylabel.module
@@ -195,13 +195,40 @@ function auto_entitylabel_field_attach_presave($entity_type, $entity) {
+ * @param string $entity_type The entity bundle.

This is actually the entity "type"; the "bundle" usually refers to things like node types (e.g. page, article)

@broxen, @ekes: can you guys give the patch a go and confirm that this solves the problem for you as well?

@bforchhammer Thanks for the feedback! I'll post a updated patch soon. Are you sure $entity_type was just the actual type? I'm almost sure I remember it being the bundle. I'll verify when I update the patch.

I was going to suggest moving "%AutoEntityLabel%" into a constant but I figured it was out of scope for this issue. Sounds like you want it, so I'll include the new constant with my next patch.

I was wrong, $entity_type is just the type, not the bundle :)

Attached is the updated patch.

Works for me. Thanks!

I've downloaded the last dev version form Drupal.org with this patch committed and the problem is still present.
After re-saving a commerce product the entity label is set to %AutoEntityLabel% (attribute).

CORRECTION: Sorry about that - actually it works as it should. It should be my mistake. Thanks a lot for your work.

@kamenrs, I can't reproduce that. Here is what I've done so far:

1. New clean installation of Commerce Kickstart
2. Unchecked "Auto generate the product title" on: admin/structure/types/manage/product-display/fields/field_product
3. Downloaded and enabled the 7.x-1.x-dev (2014-Nov-16) version of Automatic Entity Label.
4. Cleared caches
5. Set the title pattern on: admin/commerce/config/product-variation-types/product/auto_label and selected "Automatically generate the label and hide the label field"
6. Clicked edit on a product variation via the inline entity form.
7. Clicked "Update product"
8. The title looked good, so I clicked edit again on the same product variation via the inline entity form
10. Once more, clicked "Update product". The product variation title still looks correct.
12. I clicked save for the product display, went back to the product variations, and the title was still correct.

Have you tried clearing your caches? Is there a different process you are taking than I've documented?

Thanks for the feedback!

@cravecode
Thank you very much for your lightning fast reply.
I apologize for this comment. It should have been my failure.
After some more tries I get the expected result. Everything works as it should. Really sorry about wasting your time.

Thanks for the time and efforts. I don't deserve them.

Thanks a ton for your great work. Please, excuse me.

@kamenrs no problem! I'm working on a e-commerce site an just downloaded Commerce Kickstart when I saw your comment come in. I figured it would only take a minute to document my steps so why not help someone in the process.

Glad to hear it's working, the more testing, the better! Good luck!