Per:

We need to deprecate form_error(), form_set_error() and switch to $form_state being a classed object. The attached patch tries to implement this.

CommentFileSizeAuthor
#6 form_state_6_2329111.patch28.37 KBanavarre
#5 form_state-5-2329111.patch28.37 KBanavarre
#4 form_state_4_2329111.patch14.71 KBanavarre
#3 form_state_3.patch1.04 KBanavarre
#2 form_state_2.patch28.36 KBanavarre
form_state.patch4.51 KBanavarre

Comments

anavarre’s picture

anavarre
Primary language French
Location 🇪🇺
commented
Issue summary: View changes
anavarre’s picture

anavarre
Primary language French
Location 🇪🇺
commented
StatusFileSize
new form_state_2.patch28.36 KB

As an alternative, here's an approach that, at the same time, upgrades the module to using PSR-4

anavarre’s picture

anavarre
Primary language French
Location 🇪🇺
commented
StatusFileSize
new form_state_3.patch1.04 KB

Missed one occurence.

anavarre’s picture

anavarre
Primary language French
Location 🇪🇺
commented
StatusFileSize
new form_state_4_2329111.patch14.71 KB

We should be okay now. Ignore previous patches.

anavarre’s picture

anavarre
Primary language French
Location 🇪🇺
commented
StatusFileSize
new form_state-5-2329111.patch28.37 KB

And finally, removing any PSR-0 reference.

anavarre’s picture

anavarre
Primary language French
Location 🇪🇺
commented
StatusFileSize
new form_state_6_2329111.patch28.37 KB

A typo had made it through. Rerolling.

paulmckibben’s picture

paulmckibben
he/him
Primary language English
Location Atlanta, GA
commented

This seems to already be fixed in the module code. Should this be closed?

killua99’s picture

killua99 commented
Status: Needs review » Fixed

This error was fixed in the next beta4.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.