Is there a plan to release a D8 version of this module in near future?

I was playing around with Drupal 8 & trying out HEADLESS D8 with angular themes and needed this module for making cross-origin requests. Have created a D8 version of this module.

Was wondering if someone can review the code and release a D8 version for this? Have pushed all the code to github at https://github.com/piyuesh23/cors

Comments

djbobbydrake’s picture

djbobbydrake commented

@piyuesh23 I forked your branch. I'm testing with D8 beta. I fixed a few of the api changes, but am still running into some issues. When I get this working, I guess I'll submit a pull request against your repo.

piyuesh23’s picture

piyuesh23 commented

@djbobbydrake,

Thanks for trying out the port. Yeah, i was expecting that to come around..;)

Can you submit a PR with the fixes you have right now. Also would be great if you can list down the issues you've been running into. Can take a look at them.

djbobbydrake’s picture

djbobbydrake commented

@piyuesh23, it looks like CORS is moving into core - https://www.drupal.org/node/1869548

clemens.tolboom’s picture

clemens.tolboom
Primary language Dutch
Location Groningen, 🇳🇱/🇪🇺
commented
Related issues: +#1869548: Opt-in CORS support
askibinski’s picture

askibinski commented

It has been postponed to at least 8.1.0.

FYI, there is also a .htaccess based solution available.

chr.fritsch’s picture

chr.fritsch
he/him
Primary language German
Location 🇩🇪🇪🇺🌍
commented

Hey,

i've created a sandbox module for using cors with d8.

Its a different approach and just uses the github lib https://github.com/asm89/stack-cors

https://www.drupal.org/sandbox/chr.fritsch/2460591

pkosenko’s picture

pkosenko commented

It looks to me like CORS is NOT being included in the Drupal 8.0 release, judging by the dialog about it. Someone else above suggests that it will be in Drupal 8.1 (maybe). In the meanwhile, is it possible to create an 8.0 version in the CORS module project (import piyuesh23's code?). That way it will be available when 8.0 is released.

andypost’s picture

andypost
he/him
Primary language Russian
commented
Assigned: piyuesh23 » Unassigned

How the module is different from https://github.com/previousnext/drupal_cors
Please merge the code

lookitscook’s picture

lookitscook commented

@andypost there's an open pull request to merge: https://github.com/justafish/drupal_cors/pull/4

Edit: important to note that files must be served via `private` instead of `public` for CORS headers to be added. Otherwise, they bypass Drupal and use whatever settings the server uses (so headers could still be specified via .htaccess on Apache).

jeqq’s picture

jeqq commented
Status: Active » Fixed

We have now a 8.x-1.0 version.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.