Problem/Motivation
See parent issue.
Proposed resolution
Remaining tasks
User interface changes
API changes
| Comment | File | Size | Author |
|---|---|---|---|
| #23 | 2326885-language-23.patch | 9.64 KB | tim.plunkett |
See parent issue.
| Comment | File | Size | Author |
|---|---|---|---|
| #23 | 2326885-language-23.patch | 9.64 KB | tim.plunkett |
Comments
Comment #1
sidharthapHere is the first attempt to create the class.
Comment #2
tim.plunkettCopy this one liner here.
I don't think changing this is in scope.
This should be indented one space, and start with a capital P. Also, it needs an
@FormElement("language_configuration")annotationThis class should be LanguageConfiguration
You can just
return array(, no need for a $types arrayPlease rename this 'processLanguageConfig'
submitLanguageConfiguration
Switch this order.
getDefaultOptions
Comment #4
sidharthapThank You @tim.plunkett.
Corrected #2 and here is the patch.
Comment #6
almaudoh commentedFor consistency with #2.7,
processLanguageConfig()should beprocessLanguageConfiguration()Comment #7
sidharthapThank you @almaudoh.
Updated comment #6.
Comment #9
tim.plunkettThis is not valid PHP. It should be array(get_called_class(), 'submitLanguageConfiguration')
And the method must be public.
Comment #10
sidharthapCorrected #9. Thank you @tim.plunkett.
Comment #12
vijaycs85Comment #13
tim.plunkettSo it turns out that language_configuration_element_submit() is still used in several places in core, so we should not move it into this element yet.
Also, the file was named incorrectly.
This will still fail the CMI tests.
Comment #15
vijaycs85Let's add to D8MI sprint.
Comment #16
tim.plunkettReminder that there is nothing to do here until #2326409: Annotate render element plugins is done.
Comment #17
tim.plunkettRerolled for now without the hook_element_info() removal in light of #2326409: Annotate render element plugins
Comment #19
tim.plunkettComment #21
tim.plunkettShouldn't have removed language_configuration_element_submit().
Comment #22
jibranmore then 80 chars.
We can inject these.
Comment #23
tim.plunkettMessed up the interdiff, sorry.
Comment #24
jibranThanks for the fixes.
Comment #25
webchickCommitted and pushed to 8.x. Thanks!
Comment #28
gábor hojtsyThanks all!