Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Problem/Motivation
#1837388: Provide a ParamConverter than can upcast any entity. added the ability to upcast entities based on other route parameters.
Proposed resolution
Use that for comment.reply
Remaining tasks
User interface changes
API changes
Comment | File | Size | Author |
---|---|---|---|
#6 | comment-2326707-6.patch | 6.46 KB | tim.plunkett |
Comments
Comment #1
tim.plunkettComment #2
larowlan- { name: breadcrumb_builder, priority: 100 }
Unrelated?
Comment #3
tim.plunkettAre you using something other than dreditor to review? I didn't remove this line, the line just starts with a hyphen.
Comment #4
larowlanPro tip: don't review patches on your phone
Comment #6
tim.plunkettRerolled for #2314599: Use title/url instead of l() for building breadcrumb.
Comment #7
dawehnerJust the PID is optional, so why do we check that the entity is there? Is this on 404/403 pages?
Comment #8
tim.plunkettI didn't write that originally, but I thought of it as protecting against someone altering the comment.reply route to work differently, and having the breadcrumb blow up...
Comment #9
webchickSounds reasonable. Nice to see how this new capability cleans up the code.
Committed and pushed to 8.x. Thanks!