Closed (fixed)
Project:
ImageAPI
Version:
5.x-1.x-dev
Component:
Code
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
11 Mar 2008 at 01:41 UTC
Updated:
16 May 2008 at 04:53 UTC
Jump to comment: Most recent file
Here's a D6 port for ImageAPI, to accompany the imagecache 2.0 port.
| Comment | File | Size | Author |
|---|---|---|---|
| #12 | imageapi_232623.patch | 17.86 KB | drewish |
| #11 | imageapi_232623.patch | 13.95 KB | drewish |
| #9 | imageapi_232623.patch | 15.63 KB | drewish |
| #7 | imageapi_232623.patch | 22.46 KB | drewish |
| #5 | imageapi_232623.patch | 21.95 KB | drewish |
Comments
Comment #1
dopry commented@eaton, can you figure out why your editor always does so many white space changes? ;) Cool hopefully I'll have use for this soon... I just finished some imagecache 1.x cleanups I've been meaning to get to. Now I'm sorta back into imageapi/imagecache 2.x territory...
Comment #2
drewish commentedjust wanted to say that this has been working fine with GD for me.
Comment #3
messenger commentedI am getting fails when I apply this, what version of imageapi does this patch apply against?
I realize it's a dev version, but must have been one prior to the current one?
thanks.
Comment #4
drewish commentedmessenger, it's against HEAD.
Here's an update that fixes the menu access to be D6.2 compatible and incorporates the fixes I posted in: #246203: Several bug fixes for the commandline ImageMagick module.
Comment #5
drewish commentedreviewing the last patch i realized that there have been some bug fixes in HEAD that didn't get applied to that patch... updating.
Comment #6
messenger commentedThanks for this.
I grabbed the files from CVS.
I had one fail
thanks again.
Comment #7
drewish commentedi'm guessing it was the CVS Id at the top of the file. here's and updated patch give it a try, it's got some imageapi_imagemagick changes that i don't want to untangle right now (basically it queues up operations and only calls convert once when closing the image).
Comment #8
dopry commentedI totally added everything but the 6.x menu update stuff to 5.x.... even the batch processing for imagemagick. so this will need to be re-rolled against head... and I think imageapi 1.x is feature complete now!! It's got all the goodies I want for it...
@drewish: thanks a lot for you help getting this stuff stabilized I owe you beer next time we get to hang out...
Comment #9
drewish commentedhere's a re-roll, just gave it a very cursory testing.
Comment #10
psynaptic commentedI just did a checkout of HEAD and applied the re-rolled patch by drewish on #9 and it patched successfully. Thanks drewish!
When I installed it I got an error:
I refreshed the page and it went away.
Edit: Refreshing the page just reloaded the module page with the imageapi not enabled.
Edit 2: This was because I was enabling imagecache at the same time as imageapi. I enabled imageapi first, then a toolkit (GD2 in my case) and then imagecache and it worked fine.
Comment #11
drewish commentedre-rolled patch.
Comment #12
drewish commented* removed the php version requirements check from imageapi.install file since that's in the .info file now.
* imageapi_uninstall now removes the variables.
* imageapi_default_toolkit() now checks if there is an imagetoolkit if the old default has been disabled. this fixes a problem with the menu if you don't enable the GD toolkit.
* renamed image_jpeg_quality to imageapi_jpeg_quality since it's really a separate setting.
* imageapi_imagemagick_convert was referencing WATCHDOG_ERRROR, changed that to WATCHDOG_ERROR.
Comment #13
dopry commentedcommitted to HEAD... uh-oh.
Comment #14
eaton commentedWOO! Thanks, drewish and dww. This is awesome news. ;)
Comment #15
drewish commentedeaton, either you're in the wrong issue queue or you meant to say dopry ;)
Comment #16
eaton commentedYou are in fact correct. This is the problem with having IRC open in one window and issues in another. Also, there are too many people whose names start with 'd'. ;-)
Seriously, though. Hooray! DOPRY. *grin*
Comment #17
messenger commentedI installed this without problems and it is working fine so far. Tend only to post when there's problems, but thought I'd let ya know I'm using it as is.
Comment #18
Anonymous (not verified) commentedAutomatically closed -- issue fixed for two weeks with no activity.