Closed (fixed)
Project:
Drupal core
Version:
8.0.x-dev
Component:
extension system
Priority:
Normal
Category:
Task
Assigned:
Issue tags:
Reporter:
Created:
21 Aug 2014 at 21:50 UTC
Updated:
9 Sep 2014 at 04:50 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
sunHm. The magically overloaded theme extension properties still appear to be used:
The reason is:
#2228093: Modernize theme initialization only cleaned up theme initialization. However,
ThemeHandler::rebuildThemeData()is unrelated to initialization and still operates onExtensionobjects only.Given that there is a use-case for instantiating a
Themedomain object (including base themes) within that process, we should probably rename theActiveThemeclass into justTheme. — No change in behavior. It only doesn't have to be currently active theme, you can instantiate it for any theme.However, the good news is that Drush has indeed been updated on testbots, so the other public property workarounds in the
Extensionclass are no longer necessary. :-)Comment #3
sunIn turn, let's defer that theme data rebuilding clean-up to a separate issue.
Comment #4
andypostLooks straightforward
Comment #5
dawehnerPerfect in its limited scope!
Comment #6
sunCreated #2326407: Remove magic property overloading from Extension class for cleaning up the serialization methods + refactoring the affected theme system functionality.
Comment #7
sunFWIW, this cleanup should not require a change notice.
The
Extensionclass was only introduced in D8. The workarounds removed here only had to be added for Drush compatibility (on testbots). TheExtensionclass has proper methods to retrieve all values of interest already.No code was supposed to use the temporarily added public properties. All of them were annotated with crystal clear
@todos.Comment #9
webchickNice clean-up.
Committed and pushed to 8.x. Thanks!