Remove public access to Extension::$type, ::$name, ::$filename

I read through the patch and all the changes look good here.

-   * @return \stdClass|bool
-   *   Returns a stdClass object if the module data is found containing at
-   *   least an uri property with the module path, for example
-   *   core/modules/user/user.module.
+   * @return \Drupal\Core\Extension\Extension|bool
+   *   Returns an Extension object if the module is found, FALSE otherwise.

Much better!

extension.uri_.3.patch no longer applies.

error: patch failed: core/lib/Drupal/Core/Extension/ThemeHandler.php:271
error: core/lib/Drupal/Core/Extension/ThemeHandler.php: patch does not apply
error: patch failed: core/tests/Drupal/Tests/Core/Extension/ThemeHandlerTest.php:242
error: core/tests/Drupal/Tests/Core/Extension/ThemeHandlerTest.php: patch does not apply

Rerolled, plus one new change in a test added by #2187717: Remove code duplication in system_list() and ThemeHandler::rebuildThemeData()

Ha, sorry sun :)

1. +++ b/core/lib/Drupal/Core/DrupalKernel.php
   @@ -416,7 +414,7 @@ protected function initializeContainer() {
   -      $this->registerNamespaces($this->getModuleNamespaces($container_modules));
   +      $this->registerNamespaces($this->container->getParameter('container.namespaces'));
   

   This looks like it is unrelated.

2. +++ b/core/modules/field/field.module
   +++ b/core/modules/field/field.module
   @@ -161,7 +161,7 @@ function field_system_info_alter(&$info, $file, $type) {
   
   +++ b/core/modules/locale/tests/modules/locale_test/locale_test.module
   +++ b/core/modules/locale/tests/modules/locale_test/locale_test.module
   @@ -18,7 +18,7 @@ function locale_test_system_info_alter(&$info, $file, $type) {
   
   +++ b/core/modules/locale/tests/modules/locale_test_translate/locale_test_translate.module
   @@ -13,7 +13,7 @@
    function locale_test_translate_system_info_alter(&$info, $file, $type) {
   
   +++ b/core/modules/system/tests/modules/module_test/module_test.module
   @@ -16,43 +16,43 @@ function module_test_permission() {
    function module_test_system_info_alter(&$info, $file, $type) {
   
   +++ b/core/modules/system/system.api.php
   @@ -993,19 +993,18 @@ function hook_system_breadcrumb_alter(array &$breadcrumb, array $attributes, arr
   -function hook_system_info_alter(&$info, $file, $type) {
   +function hook_system_info_alter(array &$info, \Drupal\Core\Extension\Extension $file, $type) {
   
   +++ b/core/modules/system/tests/modules/system_test/system_test.module
   +++ b/core/modules/system/tests/modules/system_test/system_test.module
   @@ -42,23 +42,23 @@ function system_test_system_info_alter(&$info, $file, $type) {
   
   +++ b/core/modules/update/tests/modules/update_test/update_test.module
   @@ -21,7 +21,7 @@
    function update_test_system_info_alter(&$info, $file) {
   

   Considering the typehint is added to the API doc for the hook lets make all the implementations correct - Missing type hinting on $file - also need to typehint theme_page_test_system_info_alter() which is currently not in the patch.

Committed 2c51074 and pushed to 8.x. Thanks!

Had to revert since this break testbots :(

Committed d8c718b and pushed to 8.x.

Create PR https://github.com/drush-ops/drush/pull/509 to fix. Back to rtbc awaiting merge of PR.

Hm. Why is it that these testbot breakages are not being caught prior to these patches being committed? This is at least the second in a week or so, and in both cases the patch looked hunky-dory in the issue queue.

extension.uri_.12.patch no longer applies.

error: patch failed: core/includes/install.core.inc:1388
error: core/includes/install.core.inc: patch does not apply
error: patch failed: core/modules/system/system.admin.inc:6
error: core/modules/system/system.admin.inc: patch does not apply
error: patch failed: core/themes/engines/twig/twig.engine:4
error: core/themes/engines/twig/twig.engine: patch does not apply

Patch #12 rerolled

Looked at https://github.com/drush-ops/drush/pull/509, it is merged.

Let's try again :)

Committed 28d0b8e and pushed to 8.x. Thanks!