Problem/Motivation

The docblock for template_preprocess_poll_bar() has a @see theme_poll_bar() in it. That function doesn't exist.

Proposed resolution

Remove '@see theme_poll_bar()' from https://api.drupal.org/api/drupal/modules%21poll%21poll.module/function/...

Remaining tasks

Remove '@see theme_poll_bar()'.

User interface changes

None.

API changes

None.

CommentFileSizeAuthor
#13 2324821-13.patch412 bytesrpayanm
#13 2324821-11.patch412 bytesrpayanm
#2 drupal7-remove-theme-poll-bar-2324821-2.patch412 bytespushpinderchauhan

Comments

elijah lynn’s picture

elijah lynn
Location Portland, Oregon
commented
Issue summary: View changes
pushpinderchauhan’s picture

pushpinderchauhan commented
Status: Active » Needs review
StatusFileSize
new drupal7-remove-theme-poll-bar-2324821-2.patch412 bytes

Please review.

elijah lynn’s picture

elijah lynn
Location Portland, Oregon
commented
Status: Needs review » Reviewed & tested by the community

Thanks!

dcam’s picture

dcam commented

Looks good. RTBC +1.

elijah lynn’s picture

elijah lynn
Location Portland, Oregon
commented
Issue summary: View changes
elijah lynn’s picture

elijah lynn
Location Portland, Oregon
commented
Issue summary: View changes

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 2: drupal7-remove-theme-poll-bar-2324821-2.patch, failed testing.

Status: Needs work » Needs review

dcam queued 2: drupal7-remove-theme-poll-bar-2324821-2.patch for re-testing.

dcam’s picture

dcam commented
Status: Needs review » Reviewed & tested by the community

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 2: drupal7-remove-theme-poll-bar-2324821-2.patch, failed testing.

Status: Needs work » Needs review

dcam queued 2: drupal7-remove-theme-poll-bar-2324821-2.patch for re-testing.

dcam’s picture

dcam commented
Status: Needs review » Reviewed & tested by the community
rpayanm’s picture

rpayanm
he/him
Primary language Spanish
commented
Status: Reviewed & tested by the community » Needs review
StatusFileSize
new 2324821-11.patch412 bytes
new 2324821-13.patch412 bytes

Trying...

rpayanm’s picture

rpayanm
he/him
Primary language Spanish
commented

Sorry for the two patches, are identical :)

dcam’s picture

dcam commented
Status: Needs review » Reviewed & tested by the community

@rpayanm
I have the impression that you uploaded these patches because you saw #2 fail earlier. That failure was due to a Testbot crash or some other kind of system failure. Unfortunately, those kinds of failures have been plaguing us for months. Testbot re-tests RTBC patches routinely, but then some of the time it crashes like that. When it has one of those failures for a 7.x patch, then it just has to be tested yet again and set back to RTBC. There's no need to reroll the patch or re-upload it. #2 is still good.

rpayanm’s picture

rpayanm
he/him
Primary language Spanish
commented

@dcam That's right, now I understanding :)

Grettings.

David_Rothstein’s picture

David_Rothstein commented
Status: Reviewed & tested by the community » Fixed

Committed to 7.x - thanks!

  • David_Rothstein committed 010a9a5 on 7.x 
    Issue #2324821 by rpayanm, er.pushpinderrana | Elijah Lynn: Remove...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.