Hi!

The W3C feed validator says that:

Sorry

This feed does not validate.
line 16, column 40: pubDate must be an RFC-822 date-time: Mo, 10 Mär 2008 17:42:43 +0100 (30 occurrences) [help]
<pubDate>Mo, 10 Mär 2008 17:42:43 +0100</pubDate>

Obviously the date is being localized what is not RFC-822 conform. (Mär instead of Mar)

I will provide more information if needed!

Andreas

CommentFileSizeAuthor
#18 232433.d5.node_.pubDate.patch1.18 KBdamien tournoud
#12 d7.node_.pubDate.patch1.22 KBmfb
#12 d6.node_.pubDate.patch2.94 KBmfb
#11 en_rss_date-232433-11.patch1.01 KBfloretan
#10 enrssdate2.patch1.05 KBmacgirvin
#3 enrssdate.patch1.08 KBmacgirvin

Comments

Shnoulle’s picture

Shnoulle commented
Version: 6.0 » 6.1

Same problem with 6.1 and french langage.

puDate had to be in EN .

(with rss feeder (Thunderbird, google, aggregator of drupal ...) All rss have the same date.)

rss.xml is OK, but not /blog/feed

Thank you

ptilu8’s picture

ptilu8 commented

Same problem

Drupal6.1
French

Invalid PubDate format

rss.xml not OK

Thx

macgirvin’s picture

macgirvin commented
Status: Active » Needs review
StatusFileSize
new enrssdate.patch1.08 KB

Give this patch a try. I haven't tested it myself because I don't have any translations but theoretically it should fix the problem. It simply forces the date to be in English when filling in the pubDate field contents for the feed.

ptilu8’s picture

ptilu8 commented

Tested, seems ok for me...

macgirvin’s picture

macgirvin commented

...If we can get one more person to test this, I'd be happy to bump it up a notch so that the change gets committed. As mentioned previously, I don't have the localisation framework to test it myself.

It's a quite serious bug for anybody not on an English default system; as all their feeds are non-validating and potentially unusable. It would be quite appropriate IMHO to mark it as 'critical'.

hsiegel’s picture

hsiegel commented

Just tested this and it works for me (german language).

This patch should be added as soon as possible, as all 6.1 users seem to have the same issue with their rss-feeds if they changed their installation from english-default.

Thx

damien tournoud’s picture

damien tournoud commented
Version: 7.x-dev » 6.1
Priority: Critical » Normal

Hum. I don't really understand why there is not the same problem on Drupal 5. Could someone clarify that?

From node_feed() in Drupal 5:

array('key' => 'pubDate', 'value' => format_date($item->created, 'custom', 'r'))

... and format_date() does not support the $langcode argument, which has been added in Drupal 6.

damien tournoud’s picture

damien tournoud commented
Version: 6.1 » 7.x-dev
Priority: Normal » Critical

Oh, and (if confirmed) this is critical (it breaks the whole feed creation mecanism), and bugs should get corrected in the current development version, than back-ported.

dries’s picture

dries commented
Status: Needs review » Needs work

The patch is not formatted properly and therefore won't apply. It needs to be re-rolled with proper line-breaking. Thanks.

macgirvin’s picture

macgirvin commented
Status: Needs work » Needs review
StatusFileSize
new enrssdate2.patch1.05 KB

Patch re-rolled - not certain how the lines got folded.

floretan’s picture

floretan commented
StatusFileSize
new en_rss_date-232433-11.patch1.01 KB

File was patching node.module.orig, which doesn't exist. Fixed in attached patch.

Besides the very long line of code (which was already there before), this looks good.

mfb’s picture

mfb
they or he
commented
Version: 6.1 » 7.x-dev
Priority: Normal » Critical
StatusFileSize
new d6.node_.pubDate.patch2.94 KB
new d7.node_.pubDate.patch1.22 KB

This is a critical bug for drupal 6.
Here's what I think is a more correct patch: the formatting has to be correct so we should use PHP date functions, not format_date().

macgirvin’s picture

macgirvin commented

+1

I concur.

mfb’s picture

mfb
they or he
commented
Component: system.module » node.module

Fixing component.

dries’s picture

dries commented

I've committed this patch to CVS HEAD and DRUPAL-6. Thanks mfb.

dries’s picture

dries commented
Status: Needs review » Fixed
Anonymous’s picture

Anonymous (not verified) commented
Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.

damien tournoud’s picture

damien tournoud commented
Version: 7.x-dev » 5.x-dev
Status: Closed (fixed) » Reviewed & tested by the community
StatusFileSize
new 232433.d5.node_.pubDate.patch1.18 KB

#212864: rss feed wrong date was also committed to the DRUPAL-5 branch, but only got released yesterday with Drupal 5.8. Here is a reroll.

drumm’s picture

drumm
he/him
Location NY, US
commented
Status: Reviewed & tested by the community » Fixed

Committed to 5.x.

Anonymous’s picture

Anonymous (not verified) commented
Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.

Bilalx’s picture

Bilalx commented
Version: 5.x-dev » 6.12
Status: Closed (fixed) » Active

Still have the same problem with the latest version of drupal

mfb’s picture

mfb
they or he
commented

@Jaafarix: Not sure why there'd still be an issue since this patch is in 6.12: http://cvs.drupal.org/viewvc.py/drupal/drupal/modules/node/node.module?a...

Bilalx’s picture

Bilalx commented

Yes I checked the patch against 6.12 and it is there. Still the publication date are in french for me, both with views and rss.xml and the feed does not validate.

I removed the date for now thanks to theming but it would be nice to have the english date in feed instead of the french one

damien tournoud’s picture

damien tournoud commented
Status: Active » Closed (fixed)

@Jaafarix: what you are seeing is a Views issue. Please see #461842: Views translates pubdate of rss feed for details.

Bilalx’s picture

Bilalx commented

I tried the patch and i have english dates now.

Thank you very much :).