payment_form_embedded() sets an #element_validate callback, but the specified callback function does not accept the necessary parameters, because it is actually a top-level form validate callback.

CommentFileSizeAuthor
#12 payment_2323627_12.patch1.67 KBxano
#7 payment_2323627_7.patch1.22 KBxano
#7 interdiff.txt754 bytesxano
#1 payment_2323627_1.patch642 bytesxano

Comments

xano’s picture

xano
he/they
Primary language English
Location Southampton
commented
Status: Active » Needs review
StatusFileSize
new payment_2323627_1.patch642 bytes
xano’s picture

xano
he/they
Primary language English
Location Southampton
commented
Related issues: +#2316351: Custom payment fields are not being saved

Status: Needs review » Needs work

The last submitted patch, 1: payment_2323627_1.patch, failed testing.

xano’s picture

xano
he/they
Primary language English
Location Southampton
commented
Status: Needs work » Needs review

Xano queued 1: payment_2323627_1.patch for re-testing.

Status: Needs review » Needs work

The last submitted patch, 1: payment_2323627_1.patch, failed testing.

xano’s picture

xano
he/they
Primary language English
Location Southampton
commented
Status: Needs work » Needs review
StatusFileSize
new interdiff.txt754 bytes
new payment_2323627_7.patch1.22 KB
xano’s picture

xano
he/they
Primary language English
Location Southampton
commented

Added a change record: https://www.drupal.org/node/2324667

xano’s picture

xano
he/they
Primary language English
Location Southampton
commented
Status: Needs review » Fixed

  • Xano committed 032583c on 7.x-1.x 
    Issue #2323627 by Xano: Fixed payment_form_embedded() validate callback...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

xano’s picture

xano
he/they
Primary language English
Location Southampton
commented
Status: Closed (fixed) » Active
StatusFileSize
new payment_2323627_12.patch1.67 KB

Right, so this broke modules that cannot alter the parent form. Let's go back to #element_validate, but make sure it works this time.

xano’s picture

xano
he/they
Primary language English
Location Southampton
commented
Status: Active » Needs review
xano’s picture

xano
he/they
Primary language English
Location Southampton
commented
Status: Needs review » Fixed

  • Xano committed 832e0ec on 7.x-1.x 
    Issue #2323627 by Xano: Fixed payment_form_embedded() validate callback...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.