Closed (fixed)
Project:
Drupal.org infrastructure
Component:
Packaging
Priority:
Major
Category:
Bug report
Assigned:
Reporter:
Created:
16 Aug 2014 at 19:06 UTC
Updated:
1 Sep 2014 at 20:00 UTC
Jump to comment: Most recent, Most recent file

Comments
Comment #1
drummSeems like the "Has project releases" checkbox has reappeared on editing sandbox projects.
Comment #2
andypostComment #3
tvn commentedComment #4
drummThese projects are affected:
https://www.drupal.org/node/2265517
https://www.drupal.org/node/2285469
https://www.drupal.org/node/2299591
https://www.drupal.org/node/2312479
https://www.drupal.org/node/2312751
The authors are all Git vetted users, so either removing releases or promoting them to full projects, are good cleanups.
Comment #5
drummIn
project_release_node_validate(), when a Git vetted user selects sandbox, and has project releases, the "Sandbox projects may not have releases. "Has project releases" checkbox cleared." message correctly shows, butworks for previews, but not node save.
Comment #6
andypostThe logic is very fragile in project_release_form_node_form_alter() and
project_release_node_validate()Comment #8
drummThat should fix it. We might want to do a bit more with
#statesinproject_release_form_node_form_alter()too.Leaving open for cleaning up the projects in #4 and checking for more after deployment. The query is
SELECT * FROM field_data_field_release_project frp INNER JOIN field_data_field_project_type fpt ON fpt.entity_id = frp.field_release_project_target_id AND fpt.field_project_type_value = 'sandbox';Not deploying yet because I want to be sure to run the existing BDD tests. This interaction does have a decent amount of testing already, but apparently not enough. My manual testing before would have been on node edit instead of node add. Git7site won't be working well enough to run tests until #968994: Multiple Values for listings of current companies and organizations makes it into a DB snapshot used by that site, I think it will be good tomorrow.
Comment #9
drummNow deployed on Drupal.org. Moving back to infra for project cleanup.
Comment #10
drummThere are no new problem releases since #4. I went ahead and turned off releases for the projects that only had dev snapshots:
https://www.drupal.org/sandbox/anybody/2312479
https://www.drupal.org/sandbox/sinasalek/2312751
https://www.drupal.org/sandbox/janvandiepen/2299591
That leaves:
https://www.drupal.org/sandbox/nicholasalipaz/2285469
https://www.drupal.org/sandbox/andrewmacpherson/refererlinkblock
Which look like they are being used as full projects, so I'll make them full projects.
Comment #11
drummNow cleaned up.