Closed (fixed)
Project:
Drupal core
Version:
8.0.x-dev
Component:
markup
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Issue tags:
Reporter:
Created:
16 Aug 2014 at 08:56 UTC
Updated:
31 Oct 2014 at 20:42 UTC
Jump to comment: Most recent, Most recent file

Comments
Comment #1
roaldumandal commentedComment #2
akalata commentedComment #3
akalata commentedComment #4
hazaSmall patch attached to implement the "inline_template" type.
Comment #5
hazaComment #6
heiket commentedComment #7
heiket commentedUpdated the issue summary to match template, added screenshot, confirmed issue.
Comment #8
heiket commentedTested Patch in #4 via simplytest.me
Tested:
Go to /admin/people/permissions
Scroll down the page
Confirmed > no more raw HTML tags visible
(Issue Review and test part of #Drupal8nz)
I am not sure if this needs further review before it can go RTBC so I leave it as needs review :). Ta!
Comment #9
heiket commentedAnd screenshot after patch was applied

Comment #10
dawehnerIt is much better to have an explicit div than a wrapper_attribute thing.
Comment #11
alexpottCan we have a screenshot in non compact mode - ie have the descriptions on the permissions page.
This looks dangerous code and the logic has changed the warning will be displayed regardless of whether the descriptions are hidden. Perhaps we could just swap the order of everything around. For example:
Comment #12
hazaYou were right, thanks alexpott.
Changed the logic of the patch as mentionned.
Screenshot with hidden description :
Comment #13
alexpott@Haza nice work! How about a screenshot with descriptions?
Comment #14
hazaWhoops, forgot that :)
Here it is :
Comment #15
akalata commentedLooks good!
Comment #16
alexpottCommitted 9ff1ef3 and pushed to 8.0.x. Thanks!
Comment #19
jibran