Part of meta-issue #2225347: [META] Replace calls to ENTITY_TYPE_load() and ENTITY_TYPE_load_multiple() with static method calls

See the detailed explanations and examples there.

CommentFileSizeAuthor
#14 2321701-14.patch3.46 KBrpayanm
#8 drupal8-entity_system-contact-load-2321701-8.patch3.46 KBtemoor
#5 drupal8-entity_system-contact-load-2321701-5.patch3.41 KBtemoor
#1 drupal8-entity_system-contact-load-2321701-1.patch3.45 KBtemoor

Comments

temoor’s picture

temoor commented
Status: Active » Needs review
StatusFileSize
new drupal8-entity_system-contact-load-2321701-1.patch3.45 KB
dawehner’s picture

dawehner
Primary language German
commented
Status: Needs review » Reviewed & tested by the community

I love this new method!

m1r1k’s picture

m1r1k commented
Issue tags: +#ams2014contest

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 1: drupal8-entity_system-contact-load-2321701-1.patch, failed testing.

temoor’s picture

temoor commented
Status: Needs work » Needs review
StatusFileSize
new drupal8-entity_system-contact-load-2321701-5.patch3.41 KB

Rerolled after #2285083: Rename contact category to contact form was applied

m1r1k’s picture

m1r1k commented
Status: Needs review » Reviewed & tested by the community
Issue tags: -

Look good after reroll

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 5: drupal8-entity_system-contact-load-2321701-5.patch, failed testing.

temoor’s picture

temoor commented
Status: Needs work » Needs review
StatusFileSize
new drupal8-entity_system-contact-load-2321701-8.patch3.46 KB

Re-rolled patch.

m1r1k’s picture

m1r1k commented
Status: Needs review » Reviewed & tested by the community

And again.

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 8: drupal8-entity_system-contact-load-2321701-8.patch, failed testing.

Status: Needs work » Needs review

Temoor queued 8: drupal8-entity_system-contact-load-2321701-8.patch for re-testing.

rpayanm queued 8: drupal8-entity_system-contact-load-2321701-8.patch for re-testing.

rpayanm’s picture

rpayanm
he/him
Primary language Spanish
commented
Title: Replace all instances of contact_category_load(), entity_load('contact_category') and entity_load_multiple('contact_category') with static method calls » Replace all instances of contact_form_load(), entity_load('contact_form') and entity_load_multiple('contact_form') with static method calls
rpayanm’s picture

rpayanm
he/him
Primary language Spanish
commented
Status: Needs review » Reviewed & tested by the community
StatusFileSize
new 2321701-14.patch3.46 KB
alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Fixed

This issue is a prioritized change (remove of deprecated code) as per #2350615: [policy, no patch] What changes can be accepted during the Drupal 8 beta phase? and it's benefits outweigh any disruption.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented

Committed 687d72d and pushed to 8.0.x. Thanks!

  • alexpott committed 687d72d on 8.0.x 
    Issue #2321701 by Temoor, rpayanm: Replace all instances of...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.