Part of meta-issue #2225347: [META] Replace calls to ENTITY_TYPE_load() and ENTITY_TYPE_load_multiple() with static method calls

See the detailed explanations and examples there.

CommentFileSizeAuthor
#10 interdiff-6-10.txt1.09 KBtemoor
#10 drupal8-entity_system-block-load-2321593-10.patch7.86 KBtemoor
#6 drupal8-entity_system-block-load-2321593-6.patch8.11 KBtemoor
#3 drupal8-entity_system-block-load-2321593-3.patch8.07 KBtemoor
#1 drupal8-entity_system-block-load-2321593-1.patch8.08 KBtemoor

Comments

temoor’s picture

temoor commented
Status: Active » Needs review
StatusFileSize
new drupal8-entity_system-block-load-2321593-1.patch8.08 KB

Status: Needs review » Needs work

The last submitted patch, 1: drupal8-entity_system-block-load-2321593-1.patch, failed testing.

temoor’s picture

temoor commented
StatusFileSize
new drupal8-entity_system-block-load-2321593-3.patch8.07 KB

Removed redundant parameter from loadMultiple call in MigrateBlockTest::testBlockMigration().

temoor’s picture

temoor commented
Status: Needs work » Needs review

Triggering bot

dawehner’s picture

dawehner
Primary language German
commented 
+++ b/core/modules/migrate_drupal/src/Tests/d6/MigrateBlockTest.php
@@ -82,7 +83,7 @@ public function setUp() {
     /** @var $blocks \Drupal\block\BlockInterface[] */

with this we can get rid of this documentation bit.

temoor’s picture

temoor commented
StatusFileSize
new drupal8-entity_system-block-load-2321593-6.patch8.11 KB

Removed documentation as described in #5

dawehner’s picture

dawehner
Primary language German
commented
Status: Needs review » Reviewed & tested by the community

Cool!

m1r1k’s picture

m1r1k commented
Issue tags: +#ams2014contest
alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Needs work 
+++ b/core/modules/block/src/BlockListBuilder.php
@@ -18,6 +18,7 @@
+use Drupal\block\Entity\Block;

@@ -399,7 +400,7 @@ public function validateForm(array &$form, FormStateInterface $form_state) {
-    $entities = entity_load_multiple('block', array_keys($form_state->getValue('blocks')));
+    $entities = Block::loadMultiple(array_keys($form_state->getValue('blocks')));

This should use the entity storage directly - which is already available ($this->storage)

temoor’s picture

temoor commented
Status: Needs work » Needs review
StatusFileSize
new drupal8-entity_system-block-load-2321593-10.patch7.86 KB
new interdiff-6-10.txt1.09 KB

Thanks!

m1r1k’s picture

m1r1k commented
Status: Needs review » Reviewed & tested by the community
Issue tags: -

Last comment was fixed. RBTC

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Fixed

Committed 5e6c455 and pushed to 8.0.x. Thanks!

  • alexpott committed 5e6c455 on 8.0.x 
    Issue #2321593 by Temoor: Replace all instances of block_load(),...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.