Part of meta-issue #2225347: [META] Replace calls to ENTITY_TYPE_load() and ENTITY_TYPE_load_multiple() with static method calls

See the detailed explanations and examples there.

CommentFileSizeAuthor
#13 drupal8-entity_system-aggregator-entity-load-2321501-13.patch2.8 KBrosinegrean
#3 drupal8-entity_system-aggregator-entity-load-2321501-3.patch2.83 KBtemoor
#1 drupal8-entity_system-aggregator-entity-load-2321501-1.patch2.83 KBtemoor

Comments

temoor’s picture

temoor commented
Status: Active » Needs review
StatusFileSize
new drupal8-entity_system-aggregator-entity-load-2321501-1.patch2.83 KB
dawehner’s picture

dawehner
Primary language German
commented
Status: Needs review » Needs work 
+++ b/core/modules/aggregator/src/Tests/FeedProcessorPluginTest.php
@@ -55,8 +58,11 @@ public function testDelete() {
+    $feedId = $feed->id();
...
+    \Drupal::entityManager()->getStorage('aggregator_feed')->resetCache(array($feedId));
...
+    $feed = Feed::load($feedId);

we do use lower case for variables, so $feed_id

temoor’s picture

temoor commented
Status: Needs work » Needs review
StatusFileSize
new drupal8-entity_system-aggregator-entity-load-2321501-3.patch2.83 KB

Renamed variable

dawehner’s picture

dawehner
Primary language German
commented
Status: Needs review » Reviewed & tested by the community

Nice! Thank you!

m1r1k’s picture

m1r1k commented
Issue tags: +#ams2014contest

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 3: drupal8-entity_system-aggregator-entity-load-2321501-3.patch, failed testing.

Status: Needs work » Needs review

Temoor queued 3: drupal8-entity_system-aggregator-entity-load-2321501-3.patch for re-testing.

dawehner’s picture

dawehner
Primary language German
commented
Status: Needs review » Reviewed & tested by the community

back to rtbc

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 3: drupal8-entity_system-aggregator-entity-load-2321501-3.patch, failed testing.

Status: Needs work » Needs review

Temoor queued 3: drupal8-entity_system-aggregator-entity-load-2321501-3.patch for re-testing.

m1r1k’s picture

m1r1k commented
Status: Needs review » Reviewed & tested by the community
Issue tags: -

Last fail was because of problems with qa.drupal.org. Back to rbtc.

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 3: drupal8-entity_system-aggregator-entity-load-2321501-3.patch, failed testing.

rosinegrean’s picture

rosinegrean commented
Status: Needs work » Needs review
StatusFileSize
new drupal8-entity_system-aggregator-entity-load-2321501-13.patch2.8 KB

Rerolled patch

prics queued 13: drupal8-entity_system-aggregator-entity-load-2321501-13.patch for re-testing.

rosinegrean’s picture

rosinegrean commented
Assigned: Unassigned » rosinegrean
oenie’s picture

oenie commented
Issue tags: +Amsterdam2014

Reviewing it now.

oenie’s picture

oenie commented
Status: Needs review » Reviewed & tested by the community

Looks fine to me, RTBC

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Fixed

Committed c329dfd and pushed to 8.0.x. Thanks!

  • alexpott committed c329dfd on 8.0.x 
    Issue #2321501 by Temoor, prics: Replace calls to aggregator_feed_load...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.