Add Pane Popup Not Working

Do you have a module for js aggregation enabled? If you have, try disabling that module.

I did have js aggregation enabled I then disabled it, it did not work in FF but did in IE7 then I enabled it agine and the same results, did not work in FF but it did in IE7. In FF it goes to a blank full page and is trying to load the page but never loads. Also in IE7 and FF the graphic do not load the ones between the () all I get is the IE x with no graphic and FF just does not show them. any clues? The only one that is not working I should say is the add custom content all the rest of the items seem to work fine.

any clues?

Yes, try the latest development snapshot and report back if it works for you, please.

I'm having the same issue with Beta 4b in FF. Did not have this issue in Beta 3. Here's the message that I get with Firebug when I attempt to click "Add pane":

modal 1 jquery.js (line 2)

elem has no properties
e(undefined, "class", undefined)jquery.js (line 2)
e("class", undefined, undefined)jquery.js (line 2)
attachPane("#panel-pane-null")display_editor.js (line 491)
bindAjaxResponse(Object type=add)modal_forms.js (line 120)
e(undefined)

Also can you suggest the best way to downgrade from Beta 4b to Beta 3? :) Running into too many issues with Beta 4b at the moment and need to get some things done ...

If you need to downgrade, just delete the /panels directory and replace it with the beta3 code. You won't need to change anything in your database.

@erniem: #230337: panels_object_cache.data is a bit small definitely isn't your issue; it's since been resolved.

Have (either of) you installed jQuery update?

@ron_s
Which version of jquery do you have? Default that comes with drupal 5.x or do you have the jQuery update module, with jquery 1.1.2?

I have the updated (1.1.2) version of jquery and cannot recreate this bug.

@noahb and @sdboyer: I'm using the default version that comes with 5.x, which I believe is 1.0.1. I have tended to stay away from updating jQuery to avoid any potential conflicts or issues with backward compatibility.

I've been running 1.0.1 all along, and didn't have a problem with Pane Popup with Panels 5.x-2.0-beta3. What I didn't understand is why all of a sudden this has become an issue in beta4. Did something change in the code that makes a newer version of jQuery a requirement?

I used jQuery Update to upgrade to 1.1.2 and the "add pane" did work. However, I'm noticing something that might be part of the reason why the earlier version of jQuery is not working.

When I try to navigate the panes under the content tab in beta4, it is painfully slow. Beta 3 was moderately slow, but this is somewhat extreme. When I clicked "add pane", it took probably 10 seconds to return back to the page. My guess is there's so much processing going on that it's overwhelming the older, and less efficient, version of jQuery.

What I don't understand is, what changed going from beta3 to beta4 that is causing such a performance drag?

@ron_s:
I don't know specifically what changes might have causes such a performance issue, but there were quite a few JavaScript commits in the cvs messages recently, so there was probably is something in there that's causing the issue you have.

I am not really experiencing any noticeable slowness with adding panes in beta4. Which browser are you testing under, so I can try to recreate?

On a completely off topic note, I saw you had some issues with date/calendar queue which I'm also experiencing as well.. We're having the same woes right now :)

I also upgraded to this specific version of this module yesterday, and am now experiencing the same issue as the title of this issue describes. I'll try jquery update and see if that fixes things.

I installed jquery update and the problem still persists for me. Still getting the js errors mentioned in #4 above.

Next step, trying latest dev snapshot, since no one here has reported trying that. Otherwise, I'll move back to beta3, I guess?

Upgraded module to 5.x-2.x-dev still the same....

Rolled back to DRUPAL-5--2-0-BETA3 (with jquery update still in place) and now I can add panes to panels pages again!

If only I knew enough about javascript to figure out why Beta 4B is having these problems. My errors throughout were the same as #4 above.

For the error:

modal 1 jquery.js (line 2)

elem has no properties
e(undefined, "class", undefined)jquery.js (line 2)
e("class", undefined, undefined)jquery.js (line 2)
attachPane("#panel-pane-null")display_editor.js (line 491)
bindAjaxResponse(Object type=add)modal_forms.js (line 120)
e(undefined)

Some thing seems to have changed from BETA3 to BETA4B. I ran a cvs diff of both, and there is actually quite a lot of stuff that has been changed between the two. Many of the changes related to the display of panes. So, many of them could be a candidate, I suppose, for causing this issue. I don't know enough about how the js gets it's info for attachPane

I am not really experiencing any noticeable slowness with adding panes in beta4. Which browser are you testing under, so I can try to recreate?

I'm running with FF 2.0.0.14. Another contributing factor could be I'm running out of space on my hard drive, so not as much virtual memory as I had before. ;)

On a completely off topic note, I saw you had some issues with date/calendar queue which I'm also experiencing as well.. We're having the same woes right now :)

I've been able to temporarily get it to do at least some of things I want it do to by making a number of changes to a templated version of phptemplate_date_display_combination, but this is just a band-aid solution.

Some thing seems to have changed from BETA3 to BETA4B.

Yeah? ;)

When I try to navigate the panes under the content tab in beta4, it is painfully slow. Beta 3 was moderately slow, but this is somewhat extreme. When I clicked "add pane", it took probably 10 seconds to return back to the page. My guess is there's so much processing going on that it's overwhelming the older, and less efficient, version of jQuery.

What I don't understand is, what changed going from beta3 to beta4 that is causing such a performance drag?

I am not suffering any kind of problem with performance.

From what I can tell, the issue quoted above is unrelated to the issue of Panes not working.

Anyone else also experiencing both issues?

I am not suffering any kind of problem with performance.

What version of jQuery are you running?

Was running what came with Drupal originally (no performance problem with that. Only problem was the problem stated in title of this issue)

As stated in my post above, I upgraded to newest jquery to attempt to fix problem stated in title of this issue

BUT

I also _rolled back_ to the old version of jquery. So, I tried BETA4B with both versions of jquery, and dev with both versions of jquery (old and jquery update) I control my site locally with mercurial, so changing stuff like this is fairly quick and easy. I download from cvs, so updates and reversals against cvs are also fairly easy. So I tried all changes listed in my posts above with original and jquery update module versions.

In all cases, no performance issue at all. (at least not on my machine). But in _all_ cases, the problem in the title of this issue persisted, save when using BETA3 with either version of jquery.

When testing with jquery_update, please test with v2.x and this patch applied: #156221: Upgrade to JQuery 1.2.6

Also, please test whether disabling jstools.module fixes this bug, if you have jstools installed.

When testing with jquery_update, please test with v2.x and this patch applied: #156221: Upgrade to JQuery 1.2.6

Do you view this as a requirement? I've read a number of issues with jQuery 1.2+ and other modules, where bugs are still being fixed.

Make sure your domains match in the settings.php and the .htaccess as shown at:

http://drupal.org/node/248099

I know this may not be your problem, but you can check. Does your FireFox error console tell you anything?

If you test with the default jQuery version (1.0) of Drupal core, this should work.
If you test with jQuery 1.1.x, then you need to use jQuery Update module 1.x.
If you test with jQuery 1.2.x, then you need to use jQuery Update module 2.x. (current development snapshot)

Please ensure that you are testing with one of these combinations. If you didn't, a wrong combination is probably the source for this bug.

Other than that, I'll debug now what could be the source of this problem.

Please test attached patch.

Just as a note, Panels doesn't recognize the global .js killswitch because it doesn't function without javascript.

Please correct me if I'm wrong: Panels might not work without JavaScript, however, we still need to make sure that all attached behaviors are executed /after/ the document DOM is loaded and ready for manipulation.

Yes. That's what the $() is for.

If you send a function through that, it's a shortcut for ready().

Good to know. :) However, we might commit these changes, too, to stay consistent with Drupal core, and also not requiring that much deep knowledge about jQuery.

Other than that, my patch included a fix for a syntax error in display_editor.js, which might be the cause for this issue.

Re-rolled patch.

And, these are simple fixes that should be included in the next release.

I'd love some reports as to whether or not htis patch actually fixes the problem people are seeing.

A couple of comments about the patch ...

First, I can't really say whether or not the patch fixes the original problem. Along the way I installed jQuery Update as suggested, upgraded to jQuery 1.1.2, and this allowed me to add panels. However, I can say implementing the patch did not cause any adverse effects. I am still experiencing some sluggishness as I reported in post #8, but I guess just will chalk it up to the module requiring more memory/processing.

Second, I'm not entirely sure the patch was rolled against the right version of code. My assumption was this patch should be against beta 4b. However in the version I have, the display_editor.js syntax error is not present. My version of display_editor.js is 1.1.2.33, and the patch seems to reference 1.1.2.35. Looks like 1.1.2.34 might be missing somewhere.

Patches are never rolled against the current release version - they're rolled against the current -dev version. In the case of Panels, -dev is what's contained in the DRUPAL-5--2 CVS branch.

this patch works for me, jquery updated to 1.2.6. Thanks!

I am a little late on this train, but, for whatever it is worth an upgrade *past* BETA4B to BETA5 cures these problems for me, using Drupal's Jquery 1.0 default core version.

So, I did not bother testing this patch, and thought it might have been rolled into the module at http://cvs.drupal.org/viewvc.py/drupal/contributions/modules/panels/js/d...

Thanks for fixing this!

That fixed the problem for me to.

After examining this patch, all it really does is add in a missing semi-colon; it removes a bunch of commented out debugging messages I want to keep (to make it easy to debug those sections again) and it adds jsEnabled killswitches that don't really do much. In D6 that killswitch has even been removed, suggesting it never really gets used.

So I did commit the missing semi-colon.

Is it updated into the beta5 release or will there be another release ?

I know its much after time but maybe this clue will help for someone.

I have tried everything what I found on uncle google.
Db patch and jquery update but still I had this same problem: no popup with content in ff and ie.

And then I got idea to switch theme to some core one and bingo.
That was the issue, duno why theme "niftyCorners" which I choose is not giving popup.

I know that is trivial, but I'm new in drupal and at the beginnig its hard to find itself in all this relations, maybe this will help for some beginners ;)