Follow-up: Node language views filters need label adjustments

I don't think its the right fix to include those languages, while it looks like a sensible stop-gap, we don't want those nodes to show up on the front page. The problem you are seeing is a side effect of #1966436: Default *content* entity languages are not set for entities created with the API. We can postpone this issue on that one, if that helps. Once that is in, nodes should be created properly in English even if no language module. Which is the intention in the first place. Entities created with no language without the language module enabled is wrooooong!

@andypost: #1740492: Implement a default entity views data handler was not yet committed? That is what this one was postponed on, right?

ok, let's [pp-1] maybe this one would be closed as duplicate as #10 said

That looks like a regression most likely introduced by #1740492: Implement a default entity views data handler to me :/

Looking for sources of the two:

$ git grep 'The language the original content'
core/modules/node/src/NodeViewsData.php:    $data['node_revision']['langcode']['help'] = t('The language the original content i

$ git grep 'The node language code'
core/modules/menu_link_content/src/Entity/MenuLinkContent.php:      ->setDescription(t('The node language code.'));
core/modules/node/src/Entity/Node.php:      ->setDescription(t('The node language code.'))

NodeViewsData.php has these for languages:

    $data['node_field_data']['langcode']['help'] = t('The language of the content or translation.');
    $data['node_field_data']['langcode']['field']['id'] = 'node_language';

    // .....

    $data['node_revision']['langcode']['help'] = t('The language the original content is in.');
    $data['node_revision']['langcode']['field']['id'] = 'node_language';

Looking at the form IDs for the 3 languages you listed, they are (in order of appearance):

name[node_field_data.langcode]
name[node_revision.langcode]
name[node_field_revision.langcode]

Indeed both node_field_revision and node_revision tables have a langcode. Looks like based on the code the node_revision one gets the nicer description, while the node_field_revision one does not. The node_field_revision value however is the ORIGINAL language code of prior revisions, no? Not sure whether we should expose that, it sounds very confusing with all the rest :D

The changes look good.

That leaves the question though why there is no content original language (as opposed to revision)? Is that because its not in out data model? Or not yet exposed? Sorry not at computer, could not check.

Re

Note that the node base table does not have langcode on it, so there is no shortcut for "the original language of this particular revision".

and

That leaves the question though why there is no content original language (as opposed to revision)? Is that because its not in out data model? Or not yet exposed? Sorry not at computer, could not check.

In terms of our data model the default language of the default revision can be accessed by filtering on node_field_data.default_language = 1. Not sure how to get views to do that in a field or a filter.

Yeah do you can get the translation language either way, but the original language is only on the revision. It is unfortunate we need to expose so much about the particularities of the data model in this way. Anyway I think the fixes are fine. The "missing" filter may not resolvable anyway. Certainly should not be here. Thought a committer would ask.

Looks great. I am also upping this to major bug, since the labels are swapped for original language vs. translation language so whoever wants to build a view would build the wrong kind of view vs. what they wanted.

+++ b/core/modules/views/tests/src/Unit/EntityViewsDataTest.php
@@ -303,7 +303,7 @@ public function testBaseTableFields() {
     $this->assertLanguageField($data['entity_test']['langcode']);
-    $this->assertEquals('Translation language', $data['entity_test']['langcode']['title']);
+    $this->assertEquals('Original language', $data['entity_test']['langcode']['title']);
 
     $this->assertStringField($data['entity_test']['name']);
 
@@ -502,7 +502,7 @@ public function testRevisionTableFields() {

@@ -502,7 +502,7 @@ public function testRevisionTableFields() {
     $this->assertNumericField($data['entity_test_mulrev_property_revision']['id']);
 
     $this->assertLanguageField($data['entity_test_mulrev_property_revision']['langcode']);
-    $this->assertEquals('Original language', $data['entity_test_mulrev_property_revision']['langcode']['title']);
+    $this->assertEquals('Translation language', $data['entity_test_mulrev_property_revision']['langcode']['title']);

Ha, there was even a test for it.

+1 in general

Committed 8ff6a61 and pushed to 8.0.x. Thanks!

Amazing, thanks!