Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Follow-up from #2318633: Add Picture module support.
Comment | File | Size | Author |
---|---|---|---|
#10 | 2319215-Add-Breakpoints-module-support-for-D8.patch | 1.37 KB | darol100 |
#7 | add_breakpoints_module-2319215-7.patch | 625 bytes | bserem |
Comments
Comment #1
markhalliwellThe following [default] breakpoints have been added. If you need to override them in the sub-theme, simply copy them from the base-theme, paste them into your sub-theme's
.info
file and change the values:Comment #3
bkosborneSorry to comment on a closed issue, but why are you adding individual breakpoints for the min and max separately? Shouldn't it be something like:
Comment #4
markhalliwellhttp://petegale.com/blog/css-media-queries-min-width-vs-max-width/
http://stackoverflow.com/questions/19472199/why-does-mobile-first-respon...
Using min and max limits rulesets to a specific "size" and ultimately (IMO) completely unnecessary.
The problem I see with RWD is kind of summed up perfectly in the following quote of one of the responses to that Stack Overflow question:
Most of the time you'll just need a
max-widthmin-width, especially when it's just involving determining which image style to use. This is 90% of the use case of the breakpoints module (at least to my knowledge).edit: meant to say min, not max. Also the decision was primarily based on keeping in-line with Bootstrap's variable implementations (not the deprecated ones) and letting the site builder determine how they wish to implement their "groupings": https://github.com/twbs/bootstrap/blob/v3.2.0/less/variables.less#L259-L295
Comment #5
bkosborneThanks, I see your point now. Providing both max and min breakpoints allows you to create breakpoint groups that use either the max as a limiter or the min as a limiter (mobile first).
Comment #7
bserem CreditAttribution: bserem commentedSorry for bringing this up again, and forgive my ignorance if I'm wrong, but shouldn't there be a 'min-width' on screen-sm-min and screen-md-min ?
See attached patch.
Thanks
Comment #8
markhalliwellPlease do not re-open already closed (fixed) issues. Open a new issue and reference this one in the related issues field.
Comment #9
bserem CreditAttribution: bserem commentedNo problem: https://www.drupal.org/node/2509438
Comment #10
darol100 CreditAttribution: darol100 as a volunteer and commentedThis still need to be port it to Drupal 8. Here is the patch for support for D8.
Comment #12
markhalliwell