Follow-up to #2034879: [Meta] Fix documentation that refers to enabling/disabling of modules

66 occurrences of the word "enabl" that needs to change to "install".
45 occurrences of the word "disabl' that need to be changed.

Comments

xjm’s picture

Priority: Critical » Normal
Lowell’s picture

Assigned: Unassigned » Lowell

Giving this a try

Barry Madore’s picture

Title: [Meta] Fix documentation that refers to enabling/disabling of modules » [Meta] Color module: Fix documentation that refers to enabling/disabling of modules

Re titling the issue to specify that this issue is about making these changes to the comment module.

Barry Madore’s picture

Title: [Meta] Color module: Fix documentation that refers to enabling/disabling of modules » [Meta] Comment module: Fix documentation that refers to enabling/disabling of modules

Woops, fixing that fixed title to be accurate -- comment module.

Lowell’s picture

Assigned: Lowell » Unassigned
Status: Active » Needs review
StatusFileSize
new2.89 KB

Ignored all references to enabled/disabled blocks, regions, themes.

Changed an enabled/disabled module references to block references where I thought that is what it actually meant.

Left several comments alone where I couldn't tell if they were supposed to be changed from "Modules to enable" to either "Blocks to enable" or "Modules to install"

larowlan’s picture

Status: Needs review » Needs work
+++ b/core/modules/block/block.module
@@ -32,7 +32,7 @@ function block_help($route_name, RouteMatchInterface $route_match) {
-      $output .= '<dd>' . t('You can add custom blocks, if the the <em>Custom Block</em> module is enabled on the <a href="!extend">Extend page</a>. For more information, see the <a href="!blockcontent-help">Custom Block help page</a>.', array('!extend' => \Drupal::url('system.modules_list'), '!blockcontent-help' => \Drupal::url('help.page', array('name' => 'block_content')))) . '</dd>';
+      $output .= '<dd>' . t('You can add custom blocks, if the the <em>Custom Block</em> module is installed on the <a href="!extend">Extend page</a>. For more information, see the <a href="!blockcontent-help">Custom Block help page</a>.', array('!extend' => \Drupal::url('system.modules_list'), '!blockcontent-help' => \Drupal::url('help.page', array('name' => 'block_content')))) . '</dd>';

@@ -138,7 +138,7 @@ function _block_rehash($theme = NULL) {
-      // Disabled modules are moved into the BlockInterface::BLOCK_REGION_NONE
+      // Disabled blocks are moved into the BlockInterface::BLOCK_REGION_NONE

+++ b/core/modules/block/src/BlockPluginBag.php
@@ -64,8 +64,8 @@ protected function initializePlugin($instance_id) {
-      // Ignore blocks belonging to disabled modules, but re-throw valid
-      // exceptions when the module is enabled and the plugin is misconfigured.
+      // Ignore blocks belonging to uninstalled modules, but re-throw valid
+      // exceptions when the module is installed and the plugin is misconfigured.

this issue is for comment but his code is block module?

larowlan’s picture

Title: [Meta] Comment module: Fix documentation that refers to enabling/disabling of modules » Comment module: Fix documentation that refers to enabling/disabling of modules
devin carlson’s picture

Status: Needs work » Needs review
StatusFileSize
new9.67 KB

A patch to change the occurrences of enable/disable with install/uninstall in comment.module.

LinL queued 8: fix_docs_2318813-8.patch for re-testing.

Status: Needs review » Needs work

The last submitted patch, 8: fix_docs_2318813-8.patch, failed testing.

devin carlson’s picture

Status: Needs work » Needs review
StatusFileSize
new9.68 KB

A reroll of #8.

linl’s picture

Status: Needs review » Needs work

Searching core/modules/comment/ directory for enabl and disabl, I found a couple of references to "enabled" in the js files that need changing:

ack enabl

js/comment-new-indicator.js
4: * May only be loaded for authenticated users, with the History module enabled.

js/node-new-comments-link.js
4: * May only be loaded for authenticated users, with the History module enabled.

Other than that, everything looks good.

devin carlson’s picture

Status: Needs work » Needs review
StatusFileSize
new1.08 KB
new10.76 KB

Including the feedback from #12.

linl’s picture

Status: Needs review » Reviewed & tested by the community

Thanks @Devin Carlson! That looks like all of them now.

catch’s picture

Status: Reviewed & tested by the community » Fixed

Committed/pushed to 8.0.x, thanks!

  • catch committed 09b562d on 8.0.x
    Issue #2318813 by Devin Carlson, Lowell: Comment module: Fix...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.