Closed (fixed)
Project:
Drupal core
Version:
8.0.x-dev
Component:
comment.module
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Issue tags:
Reporter:
Created:
10 Aug 2014 at 21:07 UTC
Updated:
11 Dec 2014 at 16:24 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
xjmComment #2
Lowell commentedGiving this a try
Comment #3
Barry Madore commentedRe titling the issue to specify that this issue is about making these changes to the comment module.
Comment #4
Barry Madore commentedWoops, fixing that fixed title to be accurate -- comment module.
Comment #5
Lowell commentedIgnored all references to enabled/disabled blocks, regions, themes.
Changed an enabled/disabled module references to block references where I thought that is what it actually meant.
Left several comments alone where I couldn't tell if they were supposed to be changed from "Modules to enable" to either "Blocks to enable" or "Modules to install"
Comment #6
larowlanthis issue is for comment but his code is block module?
Comment #7
larowlanComment #8
devin carlson commentedA patch to change the occurrences of enable/disable with install/uninstall in comment.module.
Comment #11
devin carlson commentedA reroll of #8.
Comment #12
linl commentedSearching
core/modules/comment/directory for enabl and disabl, I found a couple of references to "enabled" in the js files that need changing:Other than that, everything looks good.
Comment #13
devin carlson commentedIncluding the feedback from #12.
Comment #14
linl commentedThanks @Devin Carlson! That looks like all of them now.
Comment #15
catchCommitted/pushed to 8.0.x, thanks!