Action links should be hidden from VBO confirmation pages, for example in the context of admin_views (see my issue over there)

CommentFileSizeAuthor
#11 views_bulk_operations-add_css_class-2318273-11.patch737 bytesweinewmode
#9 views_bulk_operations-fix_hide_action_links-2318273-9.patch554 bytesPascalAnimateur
#5 views_bulk_operations-fix_hide_action_links-2318273-5.patch545 bytesPascalAnimateur
#1 2299973-hide_action_links.patch535 bytesPascalAnimateur

Comments

PascalAnimateur’s picture

PascalAnimateur commented
Status: Active » Needs review
StatusFileSize
new 2299973-hide_action_links.patch535 bytes

Here's a patch that hides action links on all VBO config / confirm pages using hook_preprocess_page.

Could this break anything?

  • bojanz committed 3e27b0b on 7.x-3.x 
    Issue #2318273 by bojanz, PascalAnimateur: Added Hide action links from...
bojanz’s picture

bojanz commented
Status: Needs review » Fixed

I've rewritten the isset() check to only trigger on VBO forms, instead of on all forms, and committed: http://cgit.drupalcode.org/views_bulk_operations/commit/?id=3e27b0b

Thanks for getting the work started.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

PascalAnimateur’s picture

PascalAnimateur commented
StatusFileSize
new views_bulk_operations-fix_hide_action_links-2318273-5.patch545 bytes

The latest patch (included in 7.x-3.3) doesn't work because the check should be against $_POST['op'] instead of $_POST['operation'].
Here's a patch that fixes this against 7.x-3.3.

PascalAnimateur’s picture

PascalAnimateur commented
Status: Closed (fixed) » Needs review
tessa bakker’s picture

tessa bakker
she/they
Primary language Dutch
commented
Status: Needs review » Needs work

Both patches won't work with a custom VBO action after a required validation error.

PascalAnimateur’s picture

PascalAnimateur commented

I've just tried creating a custom VBO action using Rules and add it to an admin_views bulk operations (using stock VBO 7.x-3.3), as I observed earlier the action is still visible on the confirmation step but disappears with my latest patch (changing 'operation' to 'op').

@Tessa Bakker : what do you mean by "required validation error" .. failed condition on a rule component ?

PascalAnimateur’s picture

PascalAnimateur commented
StatusFileSize
new views_bulk_operations-fix_hide_action_links-2318273-9.patch554 bytes

Updated patch which also works when confirming special actions like "Send HTML e-mail" (from mimemail module).

  • bojanz committed 3e27b0b on 8.x-1.x 
    Issue #2318273 by bojanz, PascalAnimateur: Added Hide action links from...
weinewmode’s picture

weinewmode commented
StatusFileSize
new views_bulk_operations-add_css_class-2318273-11.patch737 bytes

the views_bulk_operations-fix_hide_action_links-2318273-9.patch works. thanks.
I add a css class to the vbo confirm page for further manipulation.