Image crop does not appear if JQuery Update is set to anything above 1.8.

Comments

likewhoa’s picture

I can confirm this as well.

sokru’s picture

StatusFileSize
new9.43 KB

Since jQuery >1.8 doesn't support $.browser one needs to upgrade jCrop-library. Upgrade works on both 7.x-1.x and 7.x-2.x branches.

sokru’s picture

Status: Active » Needs review
likewhoa’s picture

Just to confirm that this doesn't affect the -dev version.

1kenthomas’s picture

^^ are you asking to confirm, or trying to say it doesn't affect -dev?

likewhoa’s picture

@1kenthomas works on -dev.

mynameiscorey’s picture

Wouldn't a better practise solution be to leverage the Libraries API and implement hook_requirements so when people install the module they are prompted to download a version of jcrop that is compatible with their existing jquery set up?

Loading the library this way has many benefits, in this situation for example it could integrate with modules like jquery_multi and allow people to choose a different version of jquery to use with this library than they are using for the rest of their site.

It also means I could immediately fix this issue without having to hack / update / patch this module.

angus_muir’s picture

I set back the version of jquery to 1.8 and all now appears to work. Crop box now appears to create proper sized images.

tomefa’s picture

The patch doesn't work for me with the 7.x-1.1 version of the module.
So i make another patch less big and that transform just the test of browser.msie.

eugene.ilyin’s picture

Patch #9 works for me.

eugene.ilyin’s picture

Status: Needs review » Reviewed & tested by the community
ram4nd’s picture

Status: Reviewed & tested by the community » Needs work

Needs a re-roll. This is for 7.x-1.x branch, right?.

eugene.ilyin’s picture

Status: Needs work » Reviewed & tested by the community

Seems it's not depends of version 1.x or 2.x because it's patch for library jCrop and it's the same for both branches.
I checked patch and it's compatible with branch 7.x-2.x

Also I propose to remove file "Jcrop/js/jquery.Jcrop.min.js" because it's not patched. I'm not sure that we need patch for it because it's not used.
If we use exact version of js library in module, I don't think that we should store all files and we can remove extra files to avoid misunderstanding and confusion.

ram4nd’s picture

Status: Reviewed & tested by the community » Needs work
Issue tags: +Novice

Still needs a re-roll.

eugene.ilyin’s picture

Status: Needs work » Needs review
StatusFileSize
new94.44 KB

Ok, I've prepared new patch for 7.x-2.x

Also I've deleted files:

  • Jcrop/js/jquery.Jcrop.min.js
  • Jcrop/js/jquery.color.js
  • Jcrop/js/jquery.min.js

because they are unused

  • ram4nd committed 6953d2d on 7.x-2.x authored by eugene.ilyin
    Issue #2316347 by eugene.ilyin, sokru, Tomefa: Doesn't work for anything...
ram4nd’s picture

Version: 7.x-1.1 » 7.x-2.x-dev
Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.