Closed (fixed)
Project:
Imagefield Crop
Version:
7.x-2.x-dev
Component:
User interface
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Issue tags:
Reporter:
Created:
6 Aug 2014 at 09:27 UTC
Updated:
10 Sep 2015 at 14:24 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
likewhoa commentedI can confirm this as well.
Comment #2
sokru commentedSince jQuery >1.8 doesn't support $.browser one needs to upgrade jCrop-library. Upgrade works on both 7.x-1.x and 7.x-2.x branches.
Comment #3
sokru commentedComment #4
likewhoa commentedJust to confirm that this doesn't affect the -dev version.
Comment #5
1kenthomas commented^^ are you asking to confirm, or trying to say it doesn't affect -dev?
Comment #6
likewhoa commented@1kenthomas works on -dev.
Comment #7
mynameiscorey commentedWouldn't a better practise solution be to leverage the Libraries API and implement hook_requirements so when people install the module they are prompted to download a version of jcrop that is compatible with their existing jquery set up?
Loading the library this way has many benefits, in this situation for example it could integrate with modules like jquery_multi and allow people to choose a different version of jquery to use with this library than they are using for the rest of their site.
It also means I could immediately fix this issue without having to hack / update / patch this module.
Comment #8
angus_muir commentedI set back the version of jquery to 1.8 and all now appears to work. Crop box now appears to create proper sized images.
Comment #9
tomefa commentedThe patch doesn't work for me with the 7.x-1.1 version of the module.
So i make another patch less big and that transform just the test of browser.msie.
Comment #10
eugene.ilyin commentedPatch #9 works for me.
Comment #11
eugene.ilyin commentedComment #12
ram4nd commentedNeeds a re-roll. This is for 7.x-1.x branch, right?.
Comment #13
eugene.ilyin commentedSeems it's not depends of version 1.x or 2.x because it's patch for library jCrop and it's the same for both branches.
I checked patch and it's compatible with branch 7.x-2.x
Also I propose to remove file "Jcrop/js/jquery.Jcrop.min.js" because it's not patched. I'm not sure that we need patch for it because it's not used.
If we use exact version of js library in module, I don't think that we should store all files and we can remove extra files to avoid misunderstanding and confusion.
Comment #14
ram4nd commentedStill needs a re-roll.
Comment #15
eugene.ilyin commentedOk, I've prepared new patch for 7.x-2.x
Also I've deleted files:
because they are unused
Comment #17
ram4nd commented