Closed (outdated)
Project:
Drupal core
Version:
7.x-dev
Component:
simpletest.module
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Issue tags:
Reporter:
Created:
5 Aug 2014 at 13:35 UTC
Updated:
27 Jan 2017 at 17:52 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
alexpottFirst implementation... to test:
(yep concurrent tests and opening results in a browser - how sweet is that!)
Comment #2
alexpottNew patch to fix a couple of things so that tests are still cleared once you've viewed the results - just duplicating the behaviour of the UI.
Comment #3
dawehnerTwo problems: the browser did not opened (haven't debugged it but i guess you should check for shell_exec == 0?).
Sadly I also don't see the test to finish, there seems to be a blocking process.
It would be great to just pass this as parameters ... but yeah not important.
ha, even a core committer does code style mistakes: else if => elseif (yes I do hate this policy)
Comment #4
alexpott@dawehner
1. This is how all the other functions in run-tests.sh
2. lol that'll teach me for copying and pasting from Drush :)
Latest patch removes dependency on parent test site actually existing.
Comment #6
cilefen commentedRerolled. If you use
--browserin this version, you get:Comment #7
cilefen commentedComment #8
cilefen commented@alexpott suggests adding a static method to SimpletestResultsForm that returns the form parts needed in run-tests.sh and also call it in SimpletestResultsForm::buildForm().
Comment #9
alexpottSomething like this...
Comment #10
dawehnerManually tested the patch, that is really cool, it works for me!
Mh, isn't the point of this ->t function that potx can scan them? Maybe we need a static wrapper for t?
Comment #11
alexpottI think we should just remove all the translation here. Because none of the assertions are translated so what's the point?
Comment #12
cilefen commented#9 works for me too. The results styling could be better themed.
Comment #13
cilefen commentedComment #14
alexpottDiscussed with @GaborHojtsy in IRC - we agreed that translation here was pointless because assertions are not translated.
Wrt to #12. I guess we could include seven's styles but that feels quite heavy and icky.
Comment #15
cilefen commentedIt is very plain as compared to the UI form.
Comment #16
cilefen commentedAlso I just noticed that on Firefox, the disclosure triangle is missing and its function doesn't work but it does work in Chrome. The web console is not really helpful on why.
Comment #17
alexpottFixed firefox.
Comment #18
cilefen commented@alexpott Agreed - fixed!
Comment #19
dawehnerPure lonely comment :P
Comment #20
webchickThis seems useful to help with debugging. Removed the phantom comment.
Committed and pushed to 8.0.x. Thanks!
Comment #22
cilefen commentedLet's backport this.