Hi,

thanks for nice module.
When I tried to configure it, I found a bug: Label display option is ignored by the module.

Steps to reproduce:

  • go to sliderfield component edit page
  • set option Label display to, for example, None
  • then go to webform view page
  • note that label is visible to user

I guess it happens because there is uninitialized #title_display option for the element (there also is theme wrapper with "form_element" instead of "webform_element" but it is ok, theme_form_element() uses title_display option).

Comments

sinasalek’s picture

sinasalek commented
Assigned: Unassigned » sinasalek

Fixing of this issue is sponsored by @culfin
You can expect a fix soon

  • sinasalek committed 1e93602 on 7.x-2.x 
    * Label display option is ingored [#2315689]
sinasalek’s picture

sinasalek commented
Status: Active » Fixed

Fixed, but in case of inline label you'll have to do some styling since slider is not compatible with display:inline

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

sinasalek’s picture

sinasalek commented
petednz’s picture

petednz commented

Have just downloaded this to try it - seems like it could/should do just what i am hoping for but Label and Description settings seem to be ignored eg
- set Label display to None, label still shows
- set Label display to Inline, label stays above
- set Description to 'show above', description still shows below

petednz’s picture

petednz commented

okay - i grabbed dev, and seem like the None option is functioning. thx. and i see you say inline won't work. fine. shall i open a new ticket about "Description above field" or has development ceased (or if i offer a patch will it be committed?)