Closed (fixed)
Project:
Google Analytics
Version:
8.x-2.x-dev
Component:
Code
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
4 Aug 2014 at 17:05 UTC
Updated:
31 May 2015 at 17:28 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
luksakThe attached patch implements the necessary changes.
Comment #2
hass commentedComment #3
hass commentedWhat about form_set_error()?
Comment #4
luksakWhat do you mean?
Comment #5
hass commentedIn the article you provided are examples for form errors and that these need to be migrated too. There are a lot of form errors in the validation function.
Comment #6
martin107 commentedThere are no occurrences of form_set_error() in the module!
plenty of \Drupal::formBuilder()->setErrorByName function calls but that is appropriate.
I don't understand #2. I suggest that this issue be advanced to critical am I wrong? The module cannot be installed otherwise, and prevents progress on all other issues.
I can confirm that this patch, does at least do that.
From https://www.drupal.org/node/2310411 There are some issues around
But those can be dealt with in a non critical issue.
Comment #7
martin107 commentedComment #8
berdirThey're not anymore :)
Updated patch converts them to $form_state->setErrorByName().
Comment #10
berdirSomething was wrong with the patch.
Comment #11
hass commented@Bedir: That looks code wise what I thought about. Let's see if the bot comes back. However it will fail in all cases because there are bugs in the QA bot.
@martin: I do not care every day if D8 DEV version is broken or not. D8 is changing and we need to follow up after core changed. However this does not make anything a bug as it worked. Such upgrades are tasks not bugs. This is not final software. Don't use it in production! You are warned.
Comment #13
berdirYeah, tests are exploding because of the randomName() change. I'd suggest to just commit this and do randomName() => randomMachineName() in a different issue or just quickly do it yourself, just needs a search and replace.
Comment #14
hass commentedThat's also new. I was more on Token and PHP filter errors...
Comment #15
martin107 commented@hass -I know this is pre-beta level software. I have worked on other pre-beta contrib modules, which have a mislabelled concept of 'branch' blocker.
It sends a message about the status of the code, that week say, which I like because it draws many eyes to the important issues.
Comment #16
hass commentedComment #17
hass commentedFixed setValue and a blindFix for Token module (Fully untested).
Comment #18
hass commentedComment #22
hass commented$form_state->setValue($element, $values);was an incorrect change. Rolling back and follow up in #2318609: Call to undefined method Drupal\Core\Form\FormBuilder::setValue()Comment #24
hass commentedThis seems to require more work.
Comment #26
hass commentedComment #31
hass commented