Problem/Motivation

When configuring an access test (Visibility rule) that doesn't provide any settings I'll get an Undefined index "settings" notice when saving the form.
This leads to a broken access test configuration.
Example for visibility rule without settings: "Node: (un)published" provided by ctools

Proposed resolution

Ensure there's at least an empty array as "settings".

Remaining tasks

Reviews needed.

User interface changes

None.

API changes

None.

CommentFileSizeAuthor
panels-undefined-index-settings.patch738 bytesdas-peter

Comments

das-peter’s picture

das-peter commented
Issue summary: View changes

Added to summary:
Example for visibility rule without settings: "Node: (un)published" provided by ctools

robmcbryde queued panels-undefined-index-settings.patch for re-testing.

joelpittet’s picture

joelpittet
he/him
Primary language English
Location Vancouver
commented
Status: Needs review » Fixed

Thanks @das-peter, I've committed this to the dev branch.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.