Problem/Motivation

I discovered that MenuLinkContentInterface is located in Entity namespace (/var/www/drupal/drupal8-core/core/modules/menu_link_content/src/Entity/MenuLinkContentInterface.php), but huge number of entities interfaces are located at /src level.

Proposed resolution

Provide a patch that move MenuLinkContentInterface to 'src' level.

Remaining tasks

No.

User interface changes

No.

API changes

No.

CommentFileSizeAuthor
#6 edit_issue_inconsistent-2313811-6.patch6.14 KBundertext
#4 edit_issue_inconsistent-2313811.patch12.8 KBundertext

Comments

andyceo’s picture

andyceo commented
Title: Inconsisting interface location: core/modules/menu_link_content/src/Entity/MenuLinkContentInterface.php » Inconsistent interface location: core/modules/menu_link_content/src/Entity/MenuLinkContentInterface.php
Issue tags: +Novice
dawehner’s picture

dawehner
Primary language German
commented

Good catch. We should indeed move it to the Drupal\menu_link_content namespace.

undertext’s picture

undertext commented
Assigned: Unassigned » undertext
undertext’s picture

undertext commented
Status: Active » Needs review
StatusFileSize
new edit_issue_inconsistent-2313811.patch12.8 KB
andyceo’s picture

andyceo commented
Status: Needs review » Needs work

@undertext:

Please, reduce the patch size with git config:

[diff]
  renames = copies

More info is here: https://www.drupal.org/documentation/git/configure

undertext’s picture

undertext commented
Status: Needs work » Needs review
StatusFileSize
new edit_issue_inconsistent-2313811-6.patch6.14 KB

@andyceo: Thanks for the instructions.
Reuploaded the patch.

andyceo’s picture

andyceo commented
Status: Needs review » Reviewed & tested by the community

Great, thank you!

Don't see any reason to stay without commit.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Fixed

Committed 19595c2 and pushed to 8.0.x. Thanks!

  • alexpott committed 19595c2 on 8.0.x 
    Issue #2313811 by undertext | andyceo: Fixed Inconsistent interface...
m1r1k’s picture

m1r1k commented
Issue tags: +#ams2014contest

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.