Form submits even if validation fails

Liam, I suspect that there are problems when the last page of the form is either empty (component list ends in a page break, for which there is an issue, or hidden due to conditionals).

It is rather a mess, but I think we need the equivalent of "This page left intentionally blank." -- some sort of message saying that all that's left to do is submit the form.

@Liam - Thanks for your excellent work on this. I set up your scenario and stepped through the code.

First, it may not be obvious that the call to each submission handler is being done from the validation handler. What it does to the form and form_state doesn't matter; only the side effect matter. The goal is to cause the desired side effects (e.g. creating or saving the draft, setting the cookies for the draft, etc) and avoid undesired side effects (sending the mail, setting messages).

Your scenario is an example of the greater problems that we currently have where the last page submits. If the submission handlers didn't think you were all done, it wouldn't submit the form. In specific, it is important that $form_state['save_draft'] be TRUE and at the bottom of webform_client_form_pages it is set to:

  $form_state['save_draft'] = $form_state['values']['op'] == $draft_op || ($node->webform['auto_save'] && !$form_state['webform_completed'] && user_is_logged_in());

Since the auto-save op isn't checked and since it (mistakenly) thinks that the form is complete, it submits the form, sending the e-mail and setting the message.

I do suspect that this bug would go away once we correct the definition of when a form is complete, but it certainly can and should be prevented.

We can fix the bug either as you've done, but ensuring that $form_state['webform_completed'] is FALSE in the test above, or by checking for the special __AUTOSAVE__ op. The intention of the line above is to say that the submission is a draft if a) it's a draft by virtue of clicking Save Draft or b) draft are saved between pages and there are more pages.

Therefore to keep the code most similar to Save Draft, I think we should exclude auto_save from the big multi-page-check IF (as your patch does) and add it to the explicit test for setting $form_state['save draft'].

I'll try this and if it looks good, post a patch later. This should go into 7.x-4.0.

Liam -- Please try this patch to see if it works equally well as yours.

This leave the problem of the form submitting unexpected when there is no error, a different issue.

Committed to 7.x-4.x and 8.x.