Page not found after adding, editing or deleting a menu link

Oh, I really wanted to have a look at that

+++ b/core/modules/menu_ui/src/Plugin/Menu/LocalAction/MenuLinkAdd.php
@@ -30,7 +30,7 @@ public function getOptions(Request $request) {
       // @todo Use RouteMatch instead of Request.
       //   https://www.drupal.org/node/2294157

Do we really still need this todo here? OT

Mh, why aren't all strings available as the title?

True!

1. +++ b/core/modules/menu_ui/src/MenuForm.php
   @@ -305,7 +305,7 @@ protected function buildOverviewTreeForm($tree, $delta) {
   -          $operations['edit']['query']['destination'] = $this->entity->url();
   +          $operations['edit']['query']['destination'] = $this->entity->getSystemPath();
   

   How are we going to help people not make this mistake in the future - would seem a really easy thing to get confused.

2. +++ b/core/modules/menu_ui/src/Plugin/Menu/LocalAction/MenuLinkAdd.php
   @@ -30,7 +30,7 @@ public function getOptions(Request $request) {
   -      $options['query']['destination'] = \Drupal::urlGenerator()->generateFromRoute($route_name, $raw_variables);
   +      $options['query']['destination'] = \Drupal::urlGenerator()->getPathFromRoute($route_name, $raw_variables);
   

   getPathFromRoute() is marked for deprecation.

+++ b/core/modules/menu_ui/src/Plugin/Menu/LocalAction/MenuLinkAdd.php
@@ -21,17 +21,7 @@ class MenuLinkAdd extends LocalActionDefault {
-    // Append the current path as destination to the query string.
-    if ($request->attributes->has(RouteObjectInterface::ROUTE_NAME)) {
-      $route_name = $request->attributes->get(RouteObjectInterface::ROUTE_NAME);
-      $raw_variables = array();
-      if ($request->attributes->has('_raw_variables')) {
-        $raw_variables = $request->attributes->get('_raw_variables')->all();
-      }
-      // @todo Use RouteMatch instead of Request.
-      //   https://www.drupal.org/node/2294157
-      $options['query']['destination'] = \Drupal::urlGenerator()->generateFromRoute($route_name, $raw_variables);
-    }
+    $options['query']['destination'] = drupal_get_destination()['destination'];

This is certainly much better. Ideally drupal_get_destination() could use something like internally, but well, that is out of scope of this issue.

This patch also fixes #2395189: Deletion of menu link results in error, so bumping to major.

How do I get the system path/set destination if I need to use something else than current path?

The edit and delete links for menu items are currently hardcoded to return back to the overview page. Does this question apply to this issue?

Thanks for fixing the tests to use routes.

The continued use of drupal_get_destination() is a bit frustrating, but I think it's the best we have right now.

Possibly should move this logic at least to the RouteMatch?

The alternative would be to make ConfirmFormHelper::buildCancelLink to accept urls instead of uris.

Note: this already works for form redirects/destination urls

Thanks. We need to make a replacement for drupal_get_destination() and/or fix the way the destination query string works, but that's beyond the scope of this patch.

This issue addresses a major bug and is allowed per https://www.drupal.org/core/beta-changes. Committed 7816819 and pushed to 8.0.x. Thanks!

Yep drupal_get_destination() does seem out-of-place. Also how are we going to ensure people don't make this mistake in contrib?