This is to facilitate better interoperability between Discounts and Giftcards as well as other modules that subtract from order/line item prices but want to do so after discounts have applied.

The patch adds an alter hook and some supporting logic to let other modules tell discount to remove other kinds of price components before discounts do their order refresh routine. Some compatibility bug fixes between Discounts and Giftcards rely on this.

CommentFileSizeAuthor
component_remove_alter_hook.patch1.6 KBdpolant

Comments

joelpittet’s picture

joelpittet
he/him
Primary language English
Location Vancouver
commented
Status: Active » Needs review

See if this passes testbot and has patch so needs review.

Status: Needs review » Needs work

The last submitted patch, component_remove_alter_hook.patch, failed testing.

mglaman’s picture

mglaman
Primary language English
Location WI, USA
commented

Would #2276335: Add discount postprocess hook provide this fix? Or does the alter need to live in the components shuffle?

joelpittet’s picture

joelpittet
he/him
Primary language English
Location Vancouver
commented
Status: Needs work » Postponed (maintainer needs more info)

Based on #3

joelpittet’s picture

joelpittet
he/him
Primary language English
Location Vancouver
commented
Status: Postponed (maintainer needs more info) » Closed (duplicate)

Closing, haven't heard back in a couple months.