I recently noticed that while running Linkit within a custom content pane in panels, the z-index from the panels modal popup causes the linkit modal popup to hide behind the panels modal when adding a linkit link to that content. After some head scratching, I figured it would be best to provide a patch to specifically define a z-index in the linkit.css file.

Comments

sk33lz’s picture

Status: Active » Needs review
StatusFileSize
new328 bytes

Here is the patch. It's against 7.x-2.x-dev.

sk33lz’s picture

Version: 7.x-3.1 » 7.x-2.6

Woops, wrong version number that we are using.

Status: Needs review » Needs work

The last submitted patch, 1: modal-hiding-behind-panels-modal-2312851-1.patch, failed testing.

sk33lz’s picture

Version: 7.x-2.6 » 7.x-2.x-dev

Changing version to try and get patch to pass.

drcolossos’s picture

We had the same problem after an jquery_update from 2.3 to 2.4 it looks like the API changed for the creation of the dialog. Passing zIndex does not work anymore. So this fixes the bug on the CSS site.

drcolossos’s picture

StatusFileSize
new833 bytes

Small investigation

From the jQuery UI docs http://jqueryui.com/changelog/1.10.0/#dialog

Removed: zIndex option.

Because of the jQuery update, version 1.10.x does not work with the supplied zIndex parameter from the linkit.dialog.js. I attached a patch that includes the fix from sk33lz as well as the removal from the function that provides the parameters.

drcolossos’s picture

Status: Needs work » Needs review

Status: Needs review » Needs work

The last submitted patch, 6: hidden-modal-2312851-6.patch, failed testing.

drcolossos’s picture

StatusFileSize
new867 bytes

loks like git diff got something wrong, once again...

dpfitzsi’s picture

Status: Needs work » Needs review

Status: Needs review » Needs work

The last submitted patch, 9: hidden-modal-2312851-9.patch, failed testing.

jody lynn’s picture

Version: 7.x-2.x-dev » 7.x-3.3
Status: Needs work » Needs review
StatusFileSize
new724 bytes

This is rerolled against version 3.3

Status: Needs review » Needs work

The last submitted patch, 12: linkit-2312851-12.patch, failed testing.

dpfitzsi’s picture

Version: 7.x-3.3 » 7.x-2.x-dev
StatusFileSize
new916 bytes

Was this for 2.x or 3.x? Testing a patch against 2.x version.

dpfitzsi’s picture

Status: Needs work » Needs review
dpfitzsi’s picture

Version: 7.x-2.x-dev » 7.x-3.x-dev
StatusFileSize
new818 bytes

Thanks Jody Lynn, here is a patch against 3.x too.

dpfitzsi’s picture

Version: 7.x-3.x-dev » 7.x-3.3

Trying patch against 3.3

dpfitzsi’s picture

StatusFileSize
new818 bytes

Status: Needs review » Needs work

The last submitted patch, 18: hidden-modal-2312851-18.patch, failed testing.

Status: Needs work » Needs review

Status: Needs review » Needs work

The last submitted patch, 18: hidden-modal-2312851-18.patch, failed testing.

dpfitzsi’s picture

No idea why the Linkit test is failing to create a test profile.

anon’s picture

I have made some changes to the patch in #18, and will do the same to the patch for 2.x.

I added .ui-dialog.ui-front.linkit-wrapper to the selector to make sure this only acts on dialogs with linkit.
Also, I will leave the zIndex as it is, for backward compatibility.

  • anon committed f332ee4 on 7.x-3.x
    Issue #2312851 by dpfitzsi, DrColossos, sk33lz, Jody Lynn: Linkit modal...
anon’s picture

Status: Needs work » Fixed

Thanks for all patches, this is now fixed in both 2.x and 3.x

  • anon committed 33dd5a6 on 7.x-2.x
    Issue #2312851 by dpfitzsi, DrColossos, sk33lz, Jody Lynn: Linkit modal...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

The last submitted patch, 16: hidden-modal-2312851-16.patch, failed testing.