I recently noticed that while running Linkit within a custom content pane in panels, the z-index from the panels modal popup causes the linkit modal popup to hide behind the panels modal when adding a linkit link to that content. After some head scratching, I figured it would be best to provide a patch to specifically define a z-index in the linkit.css file.
| Comment | File | Size | Author |
|---|---|---|---|
| #18 | hidden-modal-2312851-18.patch | 818 bytes | dpfitzsi |
| #16 | hidden-modal-2312851-16.patch | 818 bytes | dpfitzsi |
| #14 | hidden-modal-2312851-14.patch | 916 bytes | dpfitzsi |
| #12 | linkit-2312851-12.patch | 724 bytes | jody lynn |
| #9 | hidden-modal-2312851-9.patch | 867 bytes | drcolossos |
Comments
Comment #1
sk33lz commentedHere is the patch. It's against 7.x-2.x-dev.
Comment #2
sk33lz commentedWoops, wrong version number that we are using.
Comment #4
sk33lz commentedChanging version to try and get patch to pass.
Comment #5
drcolossos commentedWe had the same problem after an jquery_update from 2.3 to 2.4 it looks like the API changed for the creation of the dialog. Passing zIndex does not work anymore. So this fixes the bug on the CSS site.
Comment #6
drcolossos commentedSmall investigation
From the jQuery UI docs http://jqueryui.com/changelog/1.10.0/#dialog
Because of the jQuery update, version 1.10.x does not work with the supplied zIndex parameter from the linkit.dialog.js. I attached a patch that includes the fix from sk33lz as well as the removal from the function that provides the parameters.
Comment #7
drcolossos commentedComment #9
drcolossos commentedloks like git diff got something wrong, once again...
Comment #10
dpfitzsi commentedComment #12
jody lynnThis is rerolled against version 3.3
Comment #14
dpfitzsi commentedWas this for 2.x or 3.x? Testing a patch against 2.x version.
Comment #15
dpfitzsi commentedComment #16
dpfitzsi commentedThanks Jody Lynn, here is a patch against 3.x too.
Comment #17
dpfitzsi commentedTrying patch against 3.3
Comment #18
dpfitzsi commentedComment #22
dpfitzsi commentedNo idea why the Linkit test is failing to create a test profile.
Comment #23
anonI have made some changes to the patch in #18, and will do the same to the patch for 2.x.
I added
.ui-dialog.ui-front.linkit-wrapperto the selector to make sure this only acts on dialogs with linkit.Also, I will leave the zIndex as it is, for backward compatibility.
Comment #25
anonThanks for all patches, this is now fixed in both 2.x and 3.x