Trying to make list of subcribers(bot?) who are not confirmed their email ids. While creating view there are three options available for views types
Simplenews mailspool
Simplenews subscribers
Simplenews subcription.

I choose "Simplenews subscribers" and in views fields Simplenews subscription: Status (Subscription) , Simplenews subscriber: Activated (Activated) are available but not confirmed status. When Activated status is added as views field it is showing true(Yes) although user is not confirmed.

Am I missing something in configuration of views? don't know what category this issue should apply. Initially adding to bug request as I couldn't find any info in D.O and S.O regarding this issue.

CommentFileSizeAuthor
#4 simplenews.views-sub-status.2312745-4.patch3.51 KBadamps
#2 simplenews-2312745-1.patch3.64 KBnithinkolekar

Comments

SuleymanK’s picture

SuleymanK commented

+1

nithinkolekar’s picture

nithinkolekar commented
StatusFileSize
new simplenews-2312745-1.patch3.64 KB

Patch generated on windows system using winmerge.

issue tags removed.Why?

miro_dietiker’s picture

miro_dietiker
Location Switzerland
commented
Issue tags: -views integration, -views field, -not confirmed +Needs tests

Great, thank you for the update.

+++ includes/views/handlers/simplenews_handler_filter_subscription_status.inc	Tue Jan 06 22:59:25 2015
@@ -0,0 +1,19 @@
+      SIMPLENEWS_SUBSCRIPTION_STATUS_SUBSCRIBED => t('Subcribed'),
+      SIMPLENEWS_SUBSCRIPTION_STATUS_UNCONFIRMED => t('Not Confirmed'),
+      SIMPLENEWS_SUBSCRIPTION_STATUS_UNSUBSCRIBED => t('Unsubcribed'),

We could make a function like simplenews_status_list() that returns status code with labels.
Both of these handlers then call that definition and are even more simple, by just accessing the array through index.

Test coverage is important. Thus adding a "real" tag - tags where not removed before...
Can you provide tests and extend testSubscriptionManagement()?

adamps’s picture

adamps commented
Title: List of unconfirmed subscribers using views » Unconfirmed subscribers show as subscribed using views
StatusFileSize
new simplenews.views-sub-status.2312745-4.patch3.51 KB

I hit the same problem. Updating and fixing:

Updated issue title to clarify that it is a bug not a feature request: unconfirmed subscribers show as subscribed, where in fact these users will not get the newsletter.

Update the patch

  • use current patch standards: directories a and b, Unix line endings
  • default value is 1=SIMPLENEWS_SUBSCRIPTION_STATUS_SUBSCRIBED as per .install file
  • fix typo (Subcribed)
  • fix comments.

Sorry still no tests.

webmestre’s picture

webmestre commented

Hi,

#4 Patch doesn't work on config PHP 5.4 / MySql 5.0.51