Follow-up for #1498660: Refactor taxonomy entity properties to multilingual

Drupal\taxonomy\Plugin\views\relationship\NodeTermData plugin schema incomplete - is missing vid mappings.

CommentFileSizeAuthor
#8 NodeTermData-config-schema-is-broken-2312693-8.patch601 bytesAnonymous (not verified)
#4 NodeTermData-config-schema-is-broken-2312693-4.patch2.05 KBAnonymous (not verified)

Comments

vijaycs85’s picture

vijaycs85
Location London, UK
commented
Issue tags: +Configuration schema
andypost’s picture

andypost
he/him
Primary language Russian
commented
Issue summary: View changes
vijaycs85’s picture

vijaycs85
Location London, UK
commented

core/modules/taxonomy/tests/modules/taxonomy_test_views/test_views/views.view.test_taxonomy_node_term_data.yml has outdated keys, specifically for relation term_node_data plugin (vocabularies should be vids)

created #2316909: Revisit all built-in test/default views configuration in core

Anonymous’s picture

Anonymous (not verified) commented
Status: Active » Needs review
Issue tags: +Drupalaton 2014
StatusFileSize
new NodeTermData-config-schema-is-broken-2312693-4.patch2.05 KB

Added vid mapping; fixed the test & corrected the table name to node.

Status: Needs review » Needs work

The last submitted patch, 4: NodeTermData-config-schema-is-broken-2312693-4.patch, failed testing.

andypost’s picture

andypost
he/him
Primary language Russian
commented

@stevepurkiss looks you are not using latest core 8.0.x branch
4) is outdated and was fixed in original issue

andypost’s picture

andypost
he/him
Primary language Russian
commented

Only schema should be fixed, 1) still valid

Anonymous’s picture

Anonymous (not verified) commented
Status: Needs work » Needs review
StatusFileSize
new NodeTermData-config-schema-is-broken-2312693-8.patch601 bytes

@andypost d'oh, it's been a while ;) Thanks for the further info, let's try this one!

dawehner’s picture

dawehner
Primary language German
commented
Status: Needs review » Reviewed & tested by the community

Perfect!

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Needs work
Issue tags: +Needs issue summary update

Looks like the issue summary is not up-to-date since this patch is not doing everything mentioned. Also it would be nice to compare the schema with some real data since the test views in core are not correct - I some evidence that the change is correct :)

Anonymous’s picture

Anonymous (not verified) commented
Issue summary: View changes
Anonymous’s picture

Anonymous (not verified) commented

@alexpott I've updated the issue summary accordingly and spoken to @dawehner who said there is a test for this at core/modules/taxonomy/tests/modules/taxonomy_test_views/test_views/views.view.test_taxonomy_node_term_data.yml which I ran and here's some of the relevant output:

      relationships:
        term_node_tid:
          id: term_node_tid
          table: node
          field: term_node_tid
          relationship: none
          group_type: group
          admin_label: term
          dependencies:
            module:
              - taxonomy
          required: false
          vids:
            tags: tags
          plugin_id: node_term_data
          provider: taxonomy
Anonymous’s picture

Anonymous (not verified) commented
Status: Needs work » Needs review
dawehner’s picture

dawehner
Primary language German
commented
Status: Needs review » Reviewed & tested by the community

Totally forgot about this one.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Fixed

Committed 3660df9 and pushed to 8.0.x. Thanks!

  • alexpott committed 3660df9 on 8.0.x 
    Issue #2312693 by stevepurkiss | andypost: Fixed NodeTermData config...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.