Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Follow-up for #1498660: Refactor taxonomy entity properties to multilingual
Drupal\taxonomy\Plugin\views\relationship\NodeTermData
plugin schema incomplete - is missing vid mappings.
Comment | File | Size | Author |
---|---|---|---|
#8 | NodeTermData-config-schema-is-broken-2312693-8.patch | 601 bytes | Anonymous (not verified) |
#4 | NodeTermData-config-schema-is-broken-2312693-4.patch | 2.05 KB | Anonymous (not verified) |
Comments
Comment #1
vijaycs85Comment #2
andypostComment #3
vijaycs85created #2316909: Revisit all built-in test/default views configuration in core
Comment #4
Anonymous (not verified) CreditAttribution: Anonymous commentedAdded vid mapping; fixed the test & corrected the table name to node.
Comment #6
andypost@stevepurkiss looks you are not using latest core 8.0.x branch
4) is outdated and was fixed in original issue
Comment #7
andypostOnly schema should be fixed, 1) still valid
Comment #8
Anonymous (not verified) CreditAttribution: Anonymous commented@andypost d'oh, it's been a while ;) Thanks for the further info, let's try this one!
Comment #9
dawehnerPerfect!
Comment #10
alexpottLooks like the issue summary is not up-to-date since this patch is not doing everything mentioned. Also it would be nice to compare the schema with some real data since the test views in core are not correct - I some evidence that the change is correct :)
Comment #11
Anonymous (not verified) CreditAttribution: Anonymous commentedComment #12
Anonymous (not verified) CreditAttribution: Anonymous commented@alexpott I've updated the issue summary accordingly and spoken to @dawehner who said there is a test for this at
core/modules/taxonomy/tests/modules/taxonomy_test_views/test_views/views.view.test_taxonomy_node_term_data.yml
which I ran and here's some of the relevant output:Comment #13
Anonymous (not verified) CreditAttribution: Anonymous commentedComment #14
dawehnerTotally forgot about this one.
Comment #15
alexpottCommitted 3660df9 and pushed to 8.0.x. Thanks!