Problem/Motivation

@todo in menu.inc template_preprocess_menu_tree() to Remove backwards compatibility for $heading['class'].

Proposed resolution

Remove backwards compatibility for $heading['class'].

Remaining tasks

  • expand on the motivation, what benefit is there to removing backward compatibility?
  • make a first attempt at it (Novice)

User interface changes

No.

API changes

No?

CommentFileSizeAuthor
#5 remove_backwards-2310341-5.patch700 bytesilkkave

Comments

lanchez’s picture

lanchez commented

This was suggested to be done in another issue. I created a patch here https://www.drupal.org/node/2285493#comment-9102829 so let's see what happens.

lauriii’s picture

lauriii
he/him
Primary language Finnish
Location Finland
commented
Status: Active » Closed (duplicate)

#2285493: Remove deprecated 'class' property from #theme 'links' and #theme 'menu_tree' heading arrays

lauriii’s picture

lauriii
he/him
Primary language Finnish
Location Finland
commented
Status: Closed (duplicate) » Needs work

I was wrong. This one wasn't duplicate for #2285493: Remove deprecated 'class' property from #theme 'links' and #theme 'menu_tree' heading arrays.

lauriii’s picture

lauriii
he/him
Primary language Finnish
Location Finland
commented
Issue summary: View changes
Issue tags: +Novice
ilkkave’s picture

ilkkave commented
Status: Needs work » Needs review
StatusFileSize
new remove_backwards-2310341-5.patch700 bytes
joelpittet’s picture

joelpittet
he/him
Primary language English
Location Vancouver
commented
Status: Needs review » Reviewed & tested by the community

Thanks you @ilkkave.

I double checked through core and we aren't using ['header']['class'] anywhere.(in various iterations of that combo).

I think this needs a small change record, but I'll let a core committer be the judge on that one.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Fixed

I don't think the removal of this requires a CR - too minor a change.

Committed 34cce8d and pushed to 8.0.x. Thanks!

  • alexpott committed 34cce8d on 8.0.x 
    Issue #2310341 by ilkkave | YesCT: Remove backwards compatibility for $...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.